Fix FileConnection Dispose/Open lifecycle (#157, #153)#169
Merged
Conversation
…) state check Fixes #157: FileConnection, FileTransaction, and FileDataReader used `protected new void Dispose()` which hid the base class Dispose pattern, preventing polymorphic disposal via base type references (e.g. using statements with DbConnection type). Fixes #153: FileConnection.Open() now throws InvalidOperationException if the connection is already open, per the ADO.NET contract. Changes: - FileConnection: override Dispose(bool disposing), add Open() state check, simplify Close() to only transition state (Dispose handles resource cleanup) - FileTransaction: override Dispose(bool disposing) instead of new Dispose() - FileDataReader: override Dispose(bool disposing), move cleanup to Close() override to avoid recursion with base DbDataReader.Dispose(bool) - Update tests to use Close()+Open() pattern instead of bare re-Open() Closes #157, Closes #153 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SummarySummary
CoverageData.Common - 77.5%
Data.Csv - 90.7%
Data.Json - 81.5%
Data.Tests.Common - 88.8%
Data.Xls - 68.4%
Data.Xml - 88.2%
EFCore.Common - 68.5%
EFCore.Csv - 68.2%
EFCore.Json - 71.8%
EFCore.Xml - 73%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dispose(bool disposing)instead of usingprotected new void Dispose()inFileConnection,FileTransaction, andFileDataReaderso polymorphic disposal works correctly via base type references (e.g.using (DbConnection conn = ...))FileConnection.Open()now throwsInvalidOperationExceptionwhen called on an already-open connection, per ADO.NET contractClose()to only transition state; resource cleanup moved toDispose(bool)FileDataReaderto useClose()override for cleanup to avoid recursion with baseDbDataReader.Dispose(bool)callingClose()Close()+Open()instead of bare re-Open()for data refreshTest plan
Closes #157, Closes #153
🤖 Generated with Claude Code