Fix FileConnection Dispose/Open lifecycle (#157, #153)

src/Data.Common/ADO.NET/FileConnection.cs

@@ -201,7 +201,6 @@ public override void ChangeDatabase(string databaseName)
     /// </summary>
     public override void Close()
     {
-        (DataSourceProvider as IDisposable)?.Dispose();
         state = ConnectionState.Closed;
     }
 
@@ -233,6 +232,9 @@ public override void Close()
     /// </summary>
     public override void Open()
     {
+        if (State == ConnectionState.Open)
+            throw new InvalidOperationException("Connection is already open.");
+
         if (DataSourceProvider is null)
         {
             if (!CreateIfNotExist)
@@ -322,11 +324,15 @@ public override ValueTask DisposeAsync()
     /// <summary>
     /// Disposes the connection.
     /// </summary>
-    protected new void Dispose()
+    protected override void Dispose(bool disposing)
     {
-        (DataSourceProvider as IDisposable)?.Dispose();
-        base.Dispose();
-        state = ConnectionState.Closed;
+        if (disposing)
+        {
+            (DataSourceProvider as IDisposable)?.Dispose();
+            DataSourceProvider = null;
+            state = ConnectionState.Closed;
+        }
+        base.Dispose(disposing);
     }
 
     private DataTable GetTablesSchema()

src/Data.Common/ADO.NET/FileDataReader.cs

@@ -85,7 +85,11 @@ public override int RecordsAffected
     /// </summary>
     public override bool HasRows => result.HasRows;
 
-    public override void Close() => Dispose();
+    public override void Close()
+    {
+        log.LogDebug($"{GetType()}.{nameof(Close)}() called.");
+        fileReader.Dispose();
+    }
 
     /// <summary>
     /// Advances to the next result, when reading the results of batch SQL statements.
@@ -714,10 +718,9 @@ public override ValueTask DisposeAsync()
     /// <summary>
     /// Disposes of the resources used by this instance.
     /// </summary>
-    protected new void Dispose()
+    protected override void Dispose(bool disposing)
     {
-        log.LogDebug($"{GetType()}.{nameof(Dispose)}() called.");
-        fileReader.Dispose();
+        base.Dispose(disposing);
     }
 
     /// <summary>

src/Data.Common/ADO.NET/FileTransaction.cs

@@ -115,15 +115,18 @@ public override ValueTask DisposeAsync()
 #endif
 
     /// <inheritdoc/>
-    protected new void Dispose()
+    protected override void Dispose(bool disposing)
     {
-        log.LogDebug($"{GetType()}.{nameof(Dispose)}() called.");
+        if (disposing)
+        {
+            log.LogDebug($"{GetType()}.{nameof(Dispose)}() called.");
 
-        if (!TransactionDone)
-            Rollback();
+            if (!TransactionDone)
+                Rollback();
 
-        base.Dispose();
-        Writers.Clear();
+            Writers.Clear();
+        }
+        base.Dispose(disposing);
     }
 
     /// <inheritdoc/>

tests/Data.Tests.Common/InsertTests.cs

@@ -24,6 +24,7 @@ public static void Insert_ShouldInsertData<TFileParameter>(Func<FileConnection<T
 
             // Assert
             Assert.Equal(1, rowsAffected);
+            connection.Close();
             connection.Open();
 
             // Act - Verify the inserted record exists in the locations table
@@ -61,6 +62,7 @@ public static void Insert_ShouldInsertNullData<TFileParameter>(Func<FileConnecti
 
             // Assert
             Assert.Equal(1, rowsAffected);
+            connection.Close();
             connection.Open();
 
             // Act - Verify the inserted record exists in the locations table