fix: document SchemaUnknownWithoutData design for XSD edge case#171
Merged
Conversation
SchemaUnknownWithoutData stays hardcoded to true because the property lacks table context to detect XSD presence. RealizeSchema already handles this correctly by returning early when columns are defined. Dynamic detection would require architectural changes to the base class with negligible benefit. Closes #156 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SummarySummary
CoverageData.Common - 77.3%
Data.Csv - 90.7%
Data.Json - 81.5%
Data.Tests.Common - 88.4%
Data.Xls - 66.1%
Data.Xml - 86.8%
EFCore.Common - 68.5%
EFCore.Csv - 68.2%
EFCore.Json - 71.8%
EFCore.Xml - 73%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SchemaUnknownWithoutDataremains hardcoded totrueinXmlInsertrather than dynamically detecting XSD presenceRealizeSchemaalready handles this correctly by returning early when columns are defined (e.g. from XSD or CREATE TABLE)FileInsertWriter) with negligible benefit — the overhead is oneToDataTable()call in the rare "empty table with XSD" scenarioCloses #156
Test plan
dotnet build— 0 errors, 0 warnings (4 pre-existing warnings in EFCore.Json)dotnet test— all 557 tests pass (0 failures)InsertInto_EmptyXmlWithoutXsd_InfersSchemaFromValues) still passes🤖 Generated with Claude Code