Skip to content

fix: document SchemaUnknownWithoutData design for XSD edge case #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaveRMaltby merged 1 commit into from
Mar 23, 2026
Merged

fix: document SchemaUnknownWithoutData design for XSD edge case #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Data.Xml/XmlIO/Write/XmlInsert.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ public XmlInsert(Common.FileStatements.FileInsert fileStatement, FileConnection<
{
}

// Always true: XML schema may or may not come from an XSD file, but the property
// doesn't have table context to check. RealizeSchema handles this by returning early
// when columns are already defined (e.g. from XSD or CREATE TABLE).
public override bool SchemaUnknownWithoutData => true;

protected override void RealizeSchema(DataTable dataTable)
Expand Down
Loading