Merged
Conversation
This change fixes the non-standard method of referencing member functions for function pointer arguments in the codebase.
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the way member functions are passed to wrapper helpers by explicitly using pointers-to-member (&CPU::...) instead of unqualified function names.
- Updated
HL_WrapperandR8_Wrappercalls inins_prefix.cppto use&CPU::PFX_*. - Updated
A_Wrappercalls inins.cppto use&CPU::PFX_*.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/cpu/ins_prefix.cpp | Prefixed all PFX_* references with &CPU:: in wrapper calls. |
| core/cpu/ins.cpp | Prefixed all PFX_* references with &CPU:: in A_Wrapper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the non-standard method of referencing member functions for function pointer arguments in the codebase.