workstation-v0: add status JSON validation evidence for aggregate polish warnings#125
Open
workstation-v0: add status JSON validation evidence for aggregate polish warnings#125
Conversation
…ish warnings - Add status_check_workstation_polish() to sourceos that consumes check-workstation-polish.sh and appends WARNINGS for missing helpers or invalid keyboard policy - Call status_check_workstation_polish from status_collect - Enhance CI smoke step with type assertions (warnings/required_missing/ optional_missing are lists, ok/gnome are bools) - Add explicit smoke step 'sourceos status --json warnings includes aggregate polish checks' with pass/fail evidence output Agent-Logs-Url: https://github.com/SociOS-Linux/source-os/sessions/e1c403cd-0c1b-4d14-9aeb-48e570c3fafe Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add status JSON validation evidence for aggregate polish warnings
workstation-v0: add status JSON validation evidence for aggregate polish warnings
May 2, 2026
Member
|
Replay review: This PR is still useful but non-mergeable against current Preserve the useful pieces:
Recommended action: replay this into the same fresh workstation acceptance cleanup branch as #121 and #146, then close this PR as superseded once the replacement PR is open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #119 added aggregate polish warning integration to
sourceos statusbut was blocked on missing CI validation evidence. This applies that integration and adds an explicit validation step to the CI smoke suite.Changes
profiles/linux-dev/workstation-v0/bin/sourceosstatus_check_workstation_polish()— callscheck-workstation-polish.sh, appendsWARNINGSfor missing helpers or invalid keyboard policystatus_collect()alongside existing lampstand checks.github/workflows/workstation-scripts.ymlSmoke: sourceos status JSON parseswith type assertions (not just key presence):warnings/required_missing/optional_missingare lists;ok/gnomeare boolsSmoke: sourceos status --json warnings includes aggregate polish checksthat echoes the exact commands run and emits structured PASS/FAIL output per assertion — providing the visible evidence required for mergeSchema preserved
sourceos status --jsoncontinues to emit exactly:{"profile":"linux-dev/workstation-v0","ok":false,"gnome":false, "required_missing":[...],"optional_missing":[...],"warnings":[...]}