Skip to content

feat(doctor): integrate aggregate workstation polish validation#121

Open
Copilot wants to merge 2 commits intomainfrom
copilot/integrate-aggregate-polish-validation
Open

feat(doctor): integrate aggregate workstation polish validation#121
Copilot wants to merge 2 commits intomainfrom
copilot/integrate-aggregate-polish-validation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 2, 2026

doctor.sh had no visibility into the Mac-on-Linux polish layer — missing keyboard policy issues and absent mac-polish helpers were silent. This adds consumption of bin/check-workstation-polish.sh with warning-only (never hard-failure) signal reporting.

Changes

  • profiles/linux-dev/workstation-v0/doctor.sh
    • Added check_workstation_polish() — resolves and runs bin/check-workstation-polish.sh, parses its key=value output, records three doctor results:
      • workstation-polish:mac-helperok if check-mac-polish.sh is present, warn if missing
      • workstation-polish:keyboard-helperok if check-keyboard-policy.sh is present, warn if missing
      • workstation-polish:keyboard-policyok if policy_ok=yes, warn otherwise
    • Missing or failing aggregate helper → warn, never error; fail flag is never set by this path
    • Called from main() after check_lampstand_unit, before the GNOME block

Shape preserved

Existing JSON contract unchanged:

{
  "kind": "sourceos.doctor",
  "profile": "linux-dev/workstation-v0",
  "ok": false,
  "summary": { "ok": 11, "warn": 7, "error": 25, "info": 2 },
  "results": [
    { "level": "ok",   "name": "workstation-polish:mac-helper",    "message": "present" },
    { "level": "ok",   "name": "workstation-polish:keyboard-helper","message": "present" },
    { "level": "warn", "name": "workstation-polish:keyboard-policy","message": "not valid" }
  ]
}

Copilot AI changed the title [WIP] Integrate aggregate polish validation into doctor feat(doctor): integrate aggregate workstation polish validation May 2, 2026
Copilot AI requested a review from mdheller May 2, 2026 18:30
@mdheller mdheller marked this pull request as ready for review May 3, 2026 01:54
Copy link
Copy Markdown
Member

mdheller commented May 5, 2026

Replay review:

This PR remains conceptually relevant, but it is non-mergeable against current main and should not be merged as stale history.

Preserve the useful idea: doctor.sh should consume aggregate workstation polish output as warning-only signals so missing Mac polish / keyboard-policy helpers are visible without hard-failing the workstation profile.

Recommended action:

After the replay PR is opened, this PR can be closed as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workstation-v0: integrate aggregate polish validation into doctor

2 participants