feat(doctor): integrate aggregate workstation polish validation#121
Open
feat(doctor): integrate aggregate workstation polish validation#121
Conversation
…validation Agent-Logs-Url: https://github.com/SociOS-Linux/source-os/sessions/71b4a177-85da-4206-9974-e112f9b64e55 Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Integrate aggregate polish validation into doctor
feat(doctor): integrate aggregate workstation polish validation
May 2, 2026
Member
|
Replay review: This PR remains conceptually relevant, but it is non-mergeable against current Preserve the useful idea: Recommended action:
After the replay PR is opened, this PR can be closed as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doctor.shhad no visibility into the Mac-on-Linux polish layer — missing keyboard policy issues and absent mac-polish helpers were silent. This adds consumption ofbin/check-workstation-polish.shwith warning-only (never hard-failure) signal reporting.Changes
profiles/linux-dev/workstation-v0/doctor.shcheck_workstation_polish()— resolves and runsbin/check-workstation-polish.sh, parses its key=value output, records three doctor results:workstation-polish:mac-helper—okifcheck-mac-polish.shis present,warnif missingworkstation-polish:keyboard-helper—okifcheck-keyboard-policy.shis present,warnif missingworkstation-polish:keyboard-policy—okifpolicy_ok=yes,warnotherwisewarn, nevererror;failflag is never set by this pathmain()aftercheck_lampstand_unit, before the GNOME blockShape preserved
Existing JSON contract unchanged:
{ "kind": "sourceos.doctor", "profile": "linux-dev/workstation-v0", "ok": false, "summary": { "ok": 11, "warn": 7, "error": 25, "info": 2 }, "results": [ { "level": "ok", "name": "workstation-polish:mac-helper", "message": "present" }, { "level": "ok", "name": "workstation-polish:keyboard-helper","message": "present" }, { "level": "warn", "name": "workstation-polish:keyboard-policy","message": "not valid" } ] }