workstation-v0: extend aggregate polish helper with dock and shortcut signals#144
Closed
workstation-v0: extend aggregate polish helper with dock and shortcut signals#144
Conversation
… sections Agent-Logs-Url: https://github.com/SociOS-Linux/source-os/sessions/f1f9eef5-00aa-4455-a62e-7f9d3be341aa Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Extend aggregate polish helper with dock and shortcut signals
workstation-v0: extend aggregate polish helper with dock and shortcut signals
May 2, 2026
Member
|
Supersession review: This PR is being closed in favor of #146. Reason: #146 preserves the same aggregate-polish intent from this PR and additionally fixes the Useful content from this PR is represented in #146:
Action: close this PR as superseded; continue with #146 or replay #146 onto a fresh branch if current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aggregate polish helper (
check-workstation-polish.sh) only consumedmac_polishandkeyboard_policysections, leavingshortcut_mapandgnome_docksignals absent from the single aggregation surface needed by downstream status/doctor work.Changes
check-workstation-polish.sh— two additionalemit_sectioncalls inmain():Follows the existing pattern exactly; no changes to
emit_sectionitself.workstation-polish-validation.ymlpaths:triggers (pull_request+push).bash -nsyntax checks for the two new helpers.shortcut_map.helper=present,shortcut_map.shortcut_map=,gnome_dock.helper=present, andgnome_dock.gnome_dock_extension_lane_ok=.