workstation-v0: extend aggregate polish helper with dock and shortcut signals#146
Open
workstation-v0: extend aggregate polish helper with dock and shortcut signals#146
Conversation
… signals - Add shortcut_map and gnome_dock sections to check-workstation-polish.sh - Fix off-by-one in check-shortcut-map-contract.sh repo_root (3→4 levels up) - Update workstation-polish-validation.yml: paths triggers, syntax checks, and smoke assertions for the two new aggregate sections Agent-Logs-Url: https://github.com/SociOS-Linux/source-os/sessions/230dd866-6db4-4387-973f-323e70df10cc Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update aggregate polish helper to include dock and shortcut signals
workstation-v0: extend aggregate polish helper with dock and shortcut signals
May 2, 2026
Member
|
Replay review: This PR is the preferred version of the aggregate-polish helper work because it includes the Recommended action:
This keeps the queue clean without losing the useful off-by-one fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aggregate polish helper (
check-workstation-polish.sh) only surfacedmac_polish.*andkeyboard_policy.*signals, leaving the dock/extension and shortcut-map validators outside the aggregate plane consumed by status/doctor.Changes
check-workstation-polish.sh— adds twoemit_sectioncalls to consume the existing component helpers:Emits
shortcut_map.*andgnome_dock.*prefixed key=value lines following the existing pattern.check-shortcut-map-contract.sh— fixes a pre-existing off-by-one inrepo_root: was ascending 3 levels frombin/(landing atprofiles/) instead of 4 (repo root), causingshortcut_map=missingunconditionally.workstation-polish-validation.yml— adds both new helpers topaths:triggers, extends the syntax-check step to cover them, and adds smoke assertions forshortcut_map.helper=present,shortcut_map.shortcut_map=present,gnome_dock.helper=present, andgnome_dock.gnome_dock_extension_lane_ok=.