Skip to content

fix: sound meta signature and Justfile syntax#38

Merged
SuaveIV merged 4 commits intomainfrom
fix/sound-meta-signature
Apr 15, 2026
Merged

fix: sound meta signature and Justfile syntax#38
SuaveIV merged 4 commits intomainfrom
fix/sound-meta-signature

Conversation

@SuaveIV
Copy link
Copy Markdown
Owner

@SuaveIV SuaveIV commented Apr 15, 2026

I've updated the sound meta command to be less restrictive about its pipeline input. Previously, it only accepted Nothing or Binary, which caused it to crash when strings were piped in (like when looping over files with each). It now accepts Any input, which brings it in line with the other commands and fixes the reported pipe issues.

I also noticed the Binary type was still listed in the signature even though the code explicitly rejects it for now, so I've removed that to keep the API accurate.

The Justfile had a couple of Nushell syntax errors in the release recipe that I've cleared up:

  • Replaced the POSIX if/then/fi construct with a Nushell if block.
  • Fixed a variable declaration that was using @$ instead of let.

Finally, I fixed a small copy-paste error in the sound meta help text where it was still saying "file to play" instead of "file to read."

Summary by CodeRabbit

  • New Features

    • Updated sound meta command to accept diverse input types.
  • Documentation

    • Clarified sound meta command help text.
  • Chores

    • Enhanced release process with automated validation checks for configuration integrity.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Warning

Rate limit exceeded

@SuaveIV has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 41 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 41 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: dd1407e2-9b54-47df-9972-97422f6dc4d7

📥 Commits

Reviewing files that changed from the base of the PR and between 9dd0859 and cbcb6fb.

📒 Files selected for processing (1)
  • Justfile
📝 Walkthrough

Walkthrough

The changes configure Nushell as the default shell for justfile recipes, introduce a shell detection recipe, and update the release workflow to validate generated files before creating annotated version tags. The audio_meta command signature is updated to accept any input type instead of nothing, and its argument description is corrected.

Changes

Cohort / File(s) Summary
Just Build Configuration
Justfile
Added Nushell shell configuration, introduced test-shell recipe for version detection, and updated release recipe with file validation for generated artifacts and annotated tag creation.
Command Signature Updates
src/audio_meta.rs
Changed sound meta input type from Type::Nothing to Type::Any and corrected argument description from "file to play" to "file to read".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 hops with glee
Nu shell arrives, our recipes now flow,
With annotated tags we're all set to go,
Input types widen, descriptions now right,
Build systems dance in the moonlight! ✨🏷️

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: sound meta signature and Justfile syntax' accurately summarizes the two main changes in the PR: updating the sound meta command signature and fixing Nushell syntax in the Justfile.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sound-meta-signature

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SuaveIV SuaveIV linked an issue Apr 15, 2026 that may be closed by this pull request
@SuaveIV SuaveIV self-assigned this Apr 15, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Justfile`:
- Around line 67-75: The release recipe is broken for Nushell because the block
closure is immediately followed by another command and the `let version` is
scoped to a subshell; fix by placing the entire flow inside a single Nushell
command block or use proper continuations so commands run in the same shell
context: ensure `cargo smart-release --update-crates-index --execute
--changelog-without commit-statistics --no-tag` runs after the if-block
(separated by `;` or newline), and compute `let version = (cargo pkgid | str
replace -r '.*#' '' | str replace -r '.*:' '')` in the same block so the `git
tag $"v($version)" -m $"Release v($version)"` and subsequent `git push origin
main` / `git push origin $"v($version)"` can access that variable (update the
recipe containing the if-check, the cargo smart-release invocation, `let
version`, and the git tag/push lines).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46f65f13-7131-4584-ab24-5b364e074389

📥 Commits

Reviewing files that changed from the base of the PR and between 7a29988 and 9dd0859.

📒 Files selected for processing (2)
  • Justfile
  • src/audio_meta.rs

Comment thread Justfile
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@SuaveIV SuaveIV merged commit 4f331fa into main Apr 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error looping over files

1 participant