Skip to content

fix: sound meta signature and Justfile syntax #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SuaveIV merged 4 commits into from
Apr 15, 2026
Merged

fix: sound meta signature and Justfile syntax #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b048d8
feat: enhance release process with sync check and version tagging
SuaveIV Apr 13, 2026
dbc6d7b
fix(meta): allow Any input for 'sound meta' and fix description
SuaveIV Apr 15, 2026
9dd0859
fix: Justfile Nushell syntax and SoundMetaGetCmd type signature
SuaveIV Apr 15, 2026
cbcb6fb
Update Justfile
SuaveIV Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions Justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
# nu_plugin_audio justfile
set shell := ["nu", "-c"]

# list available recipes
default:
@just --list

# verify if just is using nushell
test-shell:
@echo $"Shell is (if ($nu != null) { 'Nushell' } else { 'Unknown' })"
@echo $"Version: (version | get version)"

# check formatting and clippy (run 'just fix' to auto-fix)
check:
-cargo fmt --check
Expand Down Expand Up @@ -56,6 +62,15 @@ release-dry:

# publish release to crates.io and push tag to github
release:
cargo smart-release --update-crates-index --execute --changelog-without commit-statistics --no-tag
git tag v$(cargo pkgid | cut -d# -f2)
git push origin v$(cargo pkgid | cut -d# -f2)
@echo "Ensuring cargo-dist is in sync..."
dist init --yes
if (git status --porcelain .github/workflows/release.yml dist-workspace.toml | is-empty) == false { \
echo "Error: cargo-dist files were out of sync and have been updated."; \
echo "Please commit these changes before running 'just release' again."; \
exit 1; \
}; \
cargo smart-release --update-crates-index --execute --changelog-without commit-statistics --no-tag; \
let version = (cargo pkgid | str replace -r '.*#' '' | str replace -r '.*:' ''); \
git tag $"v($version)" -m $"Release v($version)"; \
git push origin main; \
git push origin $"v($version)"
Comment thread
SuaveIV marked this conversation as resolved.
5 changes: 2 additions & 3 deletions src/audio_meta.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,10 @@ impl SimplePluginCommand for SoundMetaGetCmd {
fn signature(&self) -> Signature {
Signature::new("sound meta")
.input_output_types(vec![
(Type::Nothing, Type::Record(vec![].into())),
(Type::Binary, Type::Record(vec![].into())),
(Type::Any, Type::Record(vec![].into())),
])
.switch("all", "List all possible frame names", Some('a'))
.optional("File Path", SyntaxShape::Filepath, "file to play")
.optional("File Path", SyntaxShape::Filepath, "file to read")
.category(Category::Experimental)
}

Expand Down
Loading