bazel/tcl: migrate from rules_hdl tcl to bazel BCR tcl version#290
Conversation
|
@QuantamHD @maliberty Can you have a look and merge ? |
The tcl version in the bazel central registry supports MacOS and it can be used via MODULES.bazel instead of WORKSPACE. Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
The sta submodule needs to be modified to use the bcr tcl version. I made a PR for the change in the OpenSTA repository here: The-OpenROAD-Project/OpenSTA#290 Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
|
@QuantamHD @maliberty can you approve and merge ? |
|
mmh, looks like |
|
Ah, looks like this accidentally worked as the other PR updated this fork in a separate commit. So that commit is disconnected from anything. So this PR still needs to be merged, to then have a clean submodule update in OpenROAD. |
|
I pinged @maliberty |
|
I am holding PRs to this repo while we sort out if we will need a CLA or the like (as in the parallax repo). Hopefully it will be quick but I want ensure contributions are correctly handled. |
|
This only modifies a file that is only in this OpenROAD-Project fork, the So it only affects the OpenROAD project directly (making the build work with the BCR tcl) and thus should be covered by the OpenROAD CLA that @fredowski already signed. |
|
"should be covered by the OpenROAD CLA" - What CLA would that be? I'm not aware of any. |
|
Ah right, there might not be one. In any case, whatever requirements are good enough for OpenROAD should be good enough for changing a |
|
The existing BUILD file was created by me and so its wasn't a concern (all my work is covered by PII employment contract). It is unclear that we can say which things are GPL and which aren't in general so we need a proper solution. Sorry for the delay but this is part of bringing up this repo as more than a near mirror of Parallax. |
|
Please sign the CLA and we can merge this and your other PR |
I signed that CLA. |

The tcl version in the bazel central registry supports MacOS and it can be used via MODULES.bazel instead of WORKSPACE.