Skip to content

bazel/tcl: migrate from rules_hdl tcl to bazel BCR tcl version#290

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
fredowski:bazel-tcl
Feb 25, 2026
Merged

bazel/tcl: migrate from rules_hdl tcl to bazel BCR tcl version#290
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
fredowski:bazel-tcl

Conversation

@fredowski

Copy link
Copy Markdown
Contributor

The tcl version in the bazel central registry supports MacOS and it can be used via MODULES.bazel instead of WORKSPACE.

@hzeller

hzeller commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

@QuantamHD @maliberty Can you have a look and merge ?
That then will make it possible to get The-OpenROAD-Project/OpenROAD#9490 ready.

The tcl version in the bazel central registry supports MacOS and
it can be used via MODULES.bazel instead of WORKSPACE.

Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
fredowski added a commit to fredowski/OpenROAD that referenced this pull request Feb 22, 2026
The sta submodule needs to be modified to use the
bcr tcl version. I made a PR for the change in the
OpenSTA repository here:

The-OpenROAD-Project/OpenSTA#290

Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
@hzeller

hzeller commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

@QuantamHD @maliberty can you approve and merge ?

@hzeller

hzeller commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

mmh, looks like OpenROAD/src/sta already contains the necessary tcl change ?

@hzeller

hzeller commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Ah, looks like this accidentally worked as the other PR updated this fork in a separate commit.
https://github.com/The-OpenROAD-Project/OpenSTA/tree/7937b647b608b7d04ffc21ca9ed74c42c818f330

So that commit is disconnected from anything.

So this PR still needs to be merged, to then have a clean submodule update in OpenROAD.

@fredowski

Copy link
Copy Markdown
Contributor Author

Yes, this is github magic. The commit is in my forked OpenSTA. For me it looks like this:

Bildschirmfoto 2026-02-23 um 19 32 50

The bazel-tcl branch is the one from the tcl pr.

@QuantamHD

Copy link
Copy Markdown
Contributor

I pinged @maliberty

@maliberty

Copy link
Copy Markdown
Member

I am holding PRs to this repo while we sort out if we will need a CLA or the like (as in the parallax repo). Hopefully it will be quick but I want ensure contributions are correctly handled.

@hzeller

hzeller commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

This only modifies a file that is only in this OpenROAD-Project fork, the BUILD file, so it should not be impacted by CLA requirements on Parallax upstream.

So it only affects the OpenROAD project directly (making the build work with the BCR tcl) and thus should be covered by the OpenROAD CLA that @fredowski already signed.

@povik

povik commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

"should be covered by the OpenROAD CLA" - What CLA would that be? I'm not aware of any.

@hzeller

hzeller commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Ah right, there might not be one. In any case, whatever requirements are good enough for OpenROAD should be good enough for changing a BUILD file here, as it is only provided in this fork and used in OpenROAD.

@povik povik mentioned this pull request Feb 24, 2026
@maliberty

Copy link
Copy Markdown
Member

The existing BUILD file was created by me and so its wasn't a concern (all my work is covered by PII employment contract). It is unclear that we can say which things are GPL and which aren't in general so we need a proper solution. Sorry for the delay but this is part of bringing up this repo as more than a near mirror of Parallax.

@CLAassistant

CLAassistant commented Feb 25, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@maliberty

Copy link
Copy Markdown
Member

Please sign the CLA and we can merge this and your other PR

@fredowski

Copy link
Copy Markdown
Contributor Author

Please sign the CLA and we can merge this and your other PR

I signed that CLA.

@maliberty maliberty merged commit 7b9c3e4 into The-OpenROAD-Project:master Feb 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants