First iteration of Math Game#675
Open
Alex-RamosV wants to merge 5 commits intoTheCSharpAcademy:mainfrom
Open
Conversation
TheCSharpAcademy
requested changes
Mar 27, 2026
Owner
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@Alex-RamosV Thanks for the submission! It's looking good but there are two problems:
1- Your divisions are restricted to always having 2 as the divisor. That shouldn't be the case.
2 - It doesn't make sense to ask the user for an operation for every question. Make it so that once an operation is chosen the users will answer 5 questions for that operation, then the game will be over.
Could you please make the modifications so we can approve? 😀
IsGameOver was change to void.
Author
|
Hi there! I made the changes as requested. I felt that OOP would make it much easier, but I asked on Discord and they said the task didn't need to be done with OOP. Just to be clear I don't have too much experience with oop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.