Skip to content

Prevent bound sound path grid deletes from leaving stale DataGridView state #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Prevent bound sound path grid deletes from leaving stale DataGridView state #1202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbc538d
Initial plan
Copilot Apr 19, 2026
659a77c
Guard bound grid row deletion
Copilot Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions TombLib/TombLib.Forms/Controls/DarkDataGridViewControls.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,14 @@ private void butDelete_Click(object sender, EventArgs e)
selectedRowIndices.Sort();
selectedRowIndices.Reverse();

//Remove rows
DataGridView.CurrentCell = null;
DataGridView.ClearSelection();

// Remove rows
var rows = DataGridView.EditableRowCollection;
foreach (var selectedRowIndex in selectedRowIndices)
if (selectedRowIndex < rows.Count)
if (selectedRowIndex >= 0 && selectedRowIndex < rows.Count)
rows.RemoveAt(selectedRowIndex);

//Remove selection
foreach (var selectedRow in DataGridView.SelectedRows.Cast<DataGridViewRow>().ToList())
selectedRow.Selected = false;
}

private void butUp_Click(object sender, EventArgs e)
Expand Down