Fix: missing typing-extensions dependency and handle missing API fields while using CLI#57
Open
imyimang wants to merge 3 commits intoTrueMyst:mainfrom
Open
Fix: missing typing-extensions dependency and handle missing API fields while using CLI#57imyimang wants to merge 3 commits intoTrueMyst:mainfrom
imyimang wants to merge 3 commits intoTrueMyst:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModuleNotFoundErrorfortyping-extensionsKeyError: 'label'inspotify.pyThe application currently assumes that the Spotify API always returns a
labelfield in the album metadata. However, when fetching tracks or certain simplified album objects, this field may be missing from the JSON response{ "album_type": "album", "total_tracks": 11, "external_urls": { "spotify": "https://open.spotify.com/album/3RBULTZJ97bvVzZLpxcB0j" }, "id": "3RBULTZJ97bvVzZLpxcB0j", "images": [...], "name": "The Mountain", "release_date": "2013-09-17", "release_date_precision": "day", "type": "album", "uri": "spotify:album:3RBULTZJ97bvVzZLpxcB0j", "artists": [...], "tracks": {...}, "copyrights": [...], "genres": [] // No "label" field present }Changes:
album["label"]withalbum.get("label", "")to provide a safe fallback.After Fix:

IndexError: list index out of rangeinwrite.pyIn
write.py, thegroup_by_fontfunction fails when it encounters characters that cannot be mapped to any predefined fonts (e.g., specific symbols or unidentifiable whitespace), resulting in an emptygroupslist. Attempting to accessgroups[0]without verification causes a crash.Changes:
groupsis not empty before accessing its elements.After Fix:

