Skip to content

Fix: missing typing-extensions dependency and handle missing API fields while using CLI #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imyimang wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: missing typing-extensions dependency and handle missing API fields while using CLI #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f53fa9
fix: add missing typing-extensions dependency
imyimang Feb 12, 2026
2966207
fix: handle empty string in group_by_font function
imyimang Feb 12, 2026
687d505
fix: handle missing label field in album metadata
imyimang Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions BeatPrints/spotify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ def _get_track_metadata(self, track: dict) -> TrackMetadata:
"duration": self._format_duration(track["duration_ms"]),
"image": track["album"]["images"][0]["url"],
"label": (
album["label"]
if len(album["label"]) < 35
album.get("label", "")
if len(album.get("label", "")) < 35
else track["artists"][0]["name"]
),
"id": track["id"],
Expand Down Expand Up @@ -166,8 +166,8 @@ def _get_album_metadata(self, album: dict, shuffle: bool) -> AlbumMetadata:
),
"image": album["images"][0]["url"],
"label": (
album["label"]
if len(album["label"]) < 35
album.get("label", "")
if len(album.get("label", "")) < 35
else album["artists"][0]["name"]
),
"id": album["id"],
Expand Down
2 changes: 2 additions & 0 deletions BeatPrints/write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ def group_by_font(text: str, fonts: Dict[str, TTFont]) -> List[List[str]]:
groups.append([char, last_font_path])

# Merge consecutive characters that use the same font into one group.
if not groups:
return []
merged = [groups[0]]
for char, font_path in groups[1:]:
# Append the character to the current group.
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ questionary = "*"
rich = "*"
toml = "*"
spotipy = "*"
typing-extensions = "*"

[tool.poetry.scripts]
beatprints = 'cli.prompt:main'
Expand Down