Add random variable nodes#143
Merged
Merged
Conversation
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Merged
willGraham01
left a comment
willGraham01
left a comment
Collaborator
There was a problem hiding this comment.
Largely OK but a few comments on some naming conventions, and flagging that the signature of compute might not be able to be taken for granted. But for now we can ignore this until we have something concrete for #139, and then look at getting the two of them to play nicely.
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
willGraham01
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added nodes that represent random variables. These nodes then can be evaluated if the values of all of their parents are known/input.
This PR includes adding an assertion that labels are valid Python variable names, so that
**kwargsinterfaces can be used to set the values of nodes.Resolves #124.