Skip to content

Webcms 294 leaked cacheability metadata#1861

Open
zerihunzcgi wants to merge 2 commits into
developmentfrom
WEBCMS-294-leaked-cacheability-metadata
Open

Webcms 294 leaked cacheability metadata#1861
zerihunzcgi wants to merge 2 commits into
developmentfrom
WEBCMS-294-leaked-cacheability-metadata

Conversation

@zerihunzcgi
Copy link
Copy Markdown
Collaborator

Closes https://jira.epa.gov/browse/WEBCMS-294

Description

Fixes the issue where we see the error Error: While processing SAML authentication response, code leaked cacheability metadata when a user is logged in via SSO.

Use this section for review hints, explanations or discussion points/todos.

  • The issue is reported in samlauth module known issues, https://www.drupal.org/project/samlauth/issues/3232577
  • The fix is to avoid using destination parameter in hook_user_login without bubbling cacheability metadata
  • There is one hook_user_login implementation in our custom module that modifies destination parameter and does not use bubbling cacheability metadata
  • This PR fixs this user login in f1_sso.module

…r_login without bubbling cacheability metadata
…r_login without bubbling cacheability metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant