Skip to content

Webcms 294 leaked cacheability metadata #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zerihunzcgi wants to merge 2 commits into
base: development
Choose a base branch
from
+14 −1
Open

Webcms 294 leaked cacheability metadata #1861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71e4a21
WEBCMS-294 fix issue when modifying destination parameter in hook_use…
zerihunzcgi May 20, 2026
627229d
WEBCMS-294 fix issue when modifying destination parameter in hook_use…
zerihunzcgi May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion services/drupal/web/modules/custom/f1_sso/f1_sso.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,20 @@ function f1_sso_user_login($account) {

// Only overwrite destination if we don't already have one set.
if (empty(\Drupal::service('request_stack')->getCurrentRequest()->query->get('destination'))) {
\Drupal::service('request_stack')->getCurrentRequest()->query->set('destination', '/admin/content/my-web-areas');
$url = \Drupal\Core\Url::fromUserInput('/admin/content/my-web-areas');

//Generate absolute URL, setting to TRUE collect bubbleable metadata
$generatedUrl = $url->toString(TRUE);

$cacheability = new Drupal\Core\Cache\CacheableMetadata();
$cacheability->setCacheContexts(['user.roles', 'url.query_args']);

$response = new Drupal\Core\Routing\TrustedRedirectResponse($generatedUrl->getGeneratedUrl());
$response->addCacheableDependency($cacheability);


\Drupal::request()->query->set('destination', $generatedUrl->getGeneratedUrl());
\Drupal::service('request_stack')->getCurrentRequest()->attributes->set('_redirect', $response);
}

}