Skip to content

ci: specify node and python versions in workflows and root files - #69

Merged
hzhangxyz merged 1 commit into
mainfrom
update-versions
Jan 28, 2026
Merged

ci: specify node and python versions in workflows and root files#69
hzhangxyz merged 1 commit into
mainfrom
update-versions

Conversation

@hzhangxyz

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings January 28, 2026 10:52
@hzhangxyz
hzhangxyz merged commit 7011426 into main Jan 28, 2026
30 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes Node.js and Python version specifications across the repository by adding version files for local development tools and defining version constants in CI workflows.

Changes:

  • Added .python-version file specifying Python 3.14
  • Added .node-version file specifying Node 24
  • Introduced NODE_LATEST_VERSION environment variable in npm.yml and docs.yml workflows to centralize Node version specification

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.python-version Specifies Python 3.14 for local version managers like pyenv
.node-version Specifies Node 24 for local version managers like nvm
.github/workflows/npm.yml Adds NODE_LATEST_VERSION environment variable and uses it in setup-node action
.github/workflows/docs.yml Adds NODE_LATEST_VERSION environment variable and uses it in setup-node action

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/npm.yml
contents: read

env:
NODE_LATEST_VERSION: 24

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NODE_LATEST_VERSION environment variable is defined here and in docs.yml, but the jest.yml workflow also uses Node 24 in its test matrix without referencing this shared constant. Consider either:

  1. Moving this to a reusable workflow configuration that all Node-based workflows can share
  2. Updating jest.yml to also define and use NODE_LATEST_VERSION for consistency
  3. Using a repository-level variable or secret that all workflows can reference

This would ensure version updates only need to be made in one place.

Suggested change
NODE_LATEST_VERSION: 24
NODE_LATEST_VERSION: ${{ vars.NODE_LATEST_VERSION }}

Copilot uses AI. Check for mistakes.
Comment on lines +5 to +6
env:
NODE_LATEST_VERSION: 24

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NODE_LATEST_VERSION environment variable is duplicated here and in npm.yml. This creates a maintenance burden where version updates must be made in multiple places. Consider using a repository-level variable or a reusable workflow configuration to centralize this value across all workflows.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants