Skip to content

ci: specify node and python versions in workflows and root files #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hzhangxyz merged 1 commit into from
Jan 28, 2026
Merged

ci: specify node and python versions in workflows and root files #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Docs
permissions:
contents: read

env:
NODE_LATEST_VERSION: 24
Comment on lines +5 to +6

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NODE_LATEST_VERSION environment variable is duplicated here and in npm.yml. This creates a maintenance burden where version updates must be made in multiple places. Consider using a repository-level variable or a reusable workflow configuration to centralize this value across all workflows.

Copilot uses AI. Check for mistakes.

on:
push:
branches:
Expand All @@ -20,6 +23,7 @@ jobs:

- uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_LATEST_VERSION }}
cache: 'npm'

- name: dependencies
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Publish npm
permissions:
contents: read

env:
NODE_LATEST_VERSION: 24

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NODE_LATEST_VERSION environment variable is defined here and in docs.yml, but the jest.yml workflow also uses Node 24 in its test matrix without referencing this shared constant. Consider either:

  1. Moving this to a reusable workflow configuration that all Node-based workflows can share
  2. Updating jest.yml to also define and use NODE_LATEST_VERSION for consistency
  3. Using a repository-level variable or secret that all workflows can reference

This would ensure version updates only need to be made in one place.

Suggested change
NODE_LATEST_VERSION: 24
NODE_LATEST_VERSION: ${{ vars.NODE_LATEST_VERSION }}

Copilot uses AI. Check for mistakes.

on:
- push
- pull_request
Expand All @@ -25,6 +28,7 @@ jobs:

- uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_LATEST_VERSION }}
cache: 'npm'

- name: version
Expand Down
1 change: 1 addition & 0 deletions .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
24
1 change: 1 addition & 0 deletions .python-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.14