oh my slop (budgie sddm stuff)#372
Merged
Merged
Conversation
Contributor
ItsJamie9494
left a comment
There was a problem hiding this comment.
UX a little clunky in my opinion. Of course, I'm not a main developer here, so feel free to ignore my suggestions. One thing I do want to make sure is clarified is the expected flow for switching - the notification asks to open the wiki, but it seems you need to run the SDDM switch command manually to do anything? I don't see how that is properly explained or linked anywhere
Member
Author
|
wiki page still WIP |
Contributor
|
I would leave this as a draft then until the wiki page exists |
Owen-sz
previously approved these changes
May 29, 2026
Member
|
I meant to request changes not approve oops |
Member
Author
|
need to write the wiki page then this is go |
need to write the page later
Owen-sz
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to go into 44 and not rawhide, it will die in 45, it also depends on the removal of the configs from release in #363
this whole thing is... nasty, but it works and should provide an ok UX