chore: validate schema generation in CI#13
chore: validate schema generation in CI#13sakinaroufid wants to merge 3 commits intoUniversal-Commerce-Protocol:mainfrom
Conversation
65dd4c6 to
4362390
Compare
b5c5eb4 to
8c6661c
Compare
5d50dda to
5a8df57
Compare
|
Thank you for this contribution. We are evaluating the changes and will provide a formal response within 1 - 2 weeks. |
|
To help us review this more effectively, could you please break this CI update down into multiple logical pieces? Handling these as distinct logical units (e.g., separate commits or steps) allows us to validate the logic for each component independently and ensures our CI pipeline is modular. Thanks for your help! |
Thanks for the feedback! @nearlyforget Currently, this PR includes:
I can split this into separate PRs if that works better for review. Just to clarify the process - are you a maintainer on this project? I want to make sure I'm following the right review workflow. Cheers, |
|
Apologies for the late reply @sakinaroufid. There has been some changes on CI workflow, and yes, I'm a maintainer. |
ef7f02a to
528a988
Compare
194b5d9 to
26d9d6f
Compare
Made-with: Cursor
5a3d70e to
956a585
Compare
|
Hi @nearlyforget, I've split this into 3 separate PRs as requested!
All three pass CI and have no conflicts with main. Happy to address any feedback on the individual PRs. |
Description
Adds a pre-commit hook to catch schema sync issues before commit, plus keeps CI validation as a safety net.
Right now you can edit source schemas, forget to run generate_schemas.py, and CI will pass. Then downstream tools break because spec/ is out of sync.
The pre-commit hook gives instant feedback (seconds instead of waiting for CI). But kept the CI check too in case someone bypasses pre-commit or doesn't have it installed.
Type of change
Checklist: