chore(pre-commit): add local schema generation sync check#231
Open
sakinaroufid wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Open
chore(pre-commit): add local schema generation sync check#231sakinaroufid wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
sakinaroufid wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a pre-commit hook that runs
node generate_ts_schema_types.jsand checksgit diff --exit-code -- generated/schema-types.tsto catch schema desync locally before committing, giving instant feedback instead of waiting for CI.This complements the CI workflow added in part 1 — CI remains as a safety net for contributors who bypass or don't have pre-commit installed.
Depends on part 1 (#230) being merged first, which fixes the generator's source path so the hook produces correct output.
This is part 2 of 3 from #13, split per maintainer request.
Type of change
Checklist