Skip to content

Add FXList reference completions and diagnostics - #77

Merged
ViTeXFTW merged 1 commit into
devfrom
t3code/fxlist-reference-fields
Jul 25, 2026
Merged

Add FXList reference completions and diagnostics#77
ViTeXFTW merged 1 commit into
devfrom
t3code/fxlist-reference-fields

Conversation

@ViTeXFTW

Copy link
Copy Markdown
Owner

Summary

  • Add reference-aware completions and diagnostics for FXList-related values, including FXList:-prefixed fields.
  • Tighten suppression quick-fixes so they only apply to warnings and hints, not errors.
  • Simplify and align analysis, diagnostics, and map-reference handling around the trimmed schema and value types.
  • Update tests and docs to cover the new reference behavior and revised diagnostics model.

Testing

  • cargo test -p zerosyntax-analysis --test spec
  • cargo test -p zerosyntax-schema
  • cargo test
  • Not run: full server E2E / typing-latency checks

- Treat FXList nugget names as typed references
- Cover unresolved asset lookups in the spec
@greptile-apps

greptile-apps Bot commented Jul 25, 2026

Copy link
Copy Markdown

Greptile Summary

Adds typed FXList asset references to the schema.

  • Classifies Sound names as audio-event references.
  • Classifies RayEffect and Tracer names as object references.
  • Classifies ParticleSystem names as particle-system references.
  • Extends analysis fixtures with completion and unresolved-reference coverage for each new reference type.

Confidence Score: 5/5

The PR appears safe to merge, with the schema mappings and focused reference-analysis fixtures consistently aligned.

The changed fields resolve through existing audio-event, object, and particle-system namespaces, and the added fixtures cover both successful completion and unresolved-reference behavior without exposing a concrete regression.

Files Needing Attention: The changed schema and reference-analysis fixtures are aligned.

T-Rex T-Rex Logs

What T-Rex did

  • The contract validation run completed successfully with exit code 0.
  • The direct command output from the run was captured and retained in the fxlist-reference-spec-02-after.log artifact.
  • The fxlist-reference-spec-02-after.log artifact is available for reviewer access via its URL.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
crates/schema/schema.json Reclassifies four FXList fields as references to matching indexed declaration kinds; no actionable defect was identified.
crates/analysis/tests/spec/ReferenceTest.ini Adds representative definitions, completion anchors, and unresolved FXList reference values.
crates/analysis/tests/spec/ReferenceTest.spec.toml Adds matching completion and unresolved-reference expectations for all newly typed fields.

Reviews (1): Last reviewed commit: "Add FXList reference completions and dia..." | Re-trigger Greptile

@ViTeXFTW
ViTeXFTW merged commit da4efcc into dev Jul 25, 2026
5 checks passed
@ViTeXFTW
ViTeXFTW deleted the t3code/fxlist-reference-fields branch August 13, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant