Skip to content

Add FXList reference completions and diagnostics #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViTeXFTW merged 1 commit into from
Jul 25, 2026
Merged

Add FXList reference completions and diagnostics #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions crates/analysis/tests/spec/ReferenceTest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,39 @@ AudioEvent TestFireSound
Volume = 60.0
End

ParticleSystem TestParticleSystem
End

FXList FX_TestFire
End

FXList FX_ReferenceNuggets
Sound
Name = $11
End
Sound
Name = NoSuchFXSound
End
RayEffect
Name = $12
End
RayEffect
Name = NoSuchRayObject
End
Tracer
TracerName = $13
End
Tracer
TracerName = NoSuchTracerObject
End
ParticleSystem
Name = $14
End
ParticleSystem
Name = NoSuchParticleSystem
End
End

CommandButton Command_RefTest
ButtonImage = TestButtonImage
End
Expand Down
37 changes: 37 additions & 0 deletions crates/analysis/tests/spec/ReferenceTest.spec.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,27 @@ severity = "warning"
code = "unresolved-reference"
on = "NoSuchCommandSet"

# FXList nuggets resolve their named assets through the workspace index.
[[diag]]
severity = "warning"
code = "unresolved-reference"
on = "NoSuchFXSound"

[[diag]]
severity = "warning"
code = "unresolved-reference"
on = "NoSuchRayObject"

[[diag]]
severity = "warning"
code = "unresolved-reference"
on = "NoSuchTracerObject"

[[diag]]
severity = "warning"
code = "unresolved-reference"
on = "NoSuchParticleSystem"

# `ButtonImage =` offers the workspace's mapped images.
[[complete]]
at = "$1"
Expand Down Expand Up @@ -64,3 +85,19 @@ includes = ["RefTestCommandSet"]
[[complete]]
at = "$10"
includes = ["SET_NORMAL"]

[[complete]]
at = "$11"
includes = ["TestFireSound"]

[[complete]]
at = "$12"
includes = ["RefTestObject"]

[[complete]]
at = "$13"
includes = ["RefTestObject"]

[[complete]]
at = "$14"
includes = ["TestParticleSystem"]
12 changes: 8 additions & 4 deletions crates/schema/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5531,7 +5531,8 @@
{
"name": "Name",
"value_type": {
"kind": "ascii_string"
"kind": "reference",
"ref_kind": "audio_event"
},
"parse_fn": "INI::parseAsciiString"
}
Expand All @@ -5543,7 +5544,8 @@
{
"name": "Name",
"value_type": {
"kind": "ascii_string"
"kind": "reference",
"ref_kind": "object"
},
"parse_fn": "INI::parseAsciiString"
},
Expand All @@ -5569,7 +5571,8 @@
{
"name": "TracerName",
"value_type": {
"kind": "ascii_string"
"kind": "reference",
"ref_kind": "object"
},
"parse_fn": "INI::parseAsciiString",
"doc": null
Expand Down Expand Up @@ -5711,7 +5714,8 @@
{
"name": "Name",
"value_type": {
"kind": "ascii_string"
"kind": "reference",
"ref_kind": "particle_system"
},
"parse_fn": "INI::parseAsciiString"
},
Expand Down