You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for finding and taking time to address the issues.
Allthough it is a valid fix of current code I have a doubt merging it to master though. The problem is that mutation events (DOMNodeRemoved and DOMNodeRemovedFromDocument) are labelled as deprecated and browsers support is in process of being removed. https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Mutation_events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request fixes two issues:
destroy:composerevent is not being fired when the node is removed, as addEventListener only accepts astringastype;destroy:composerevent is not fired if any of it's parents is removed from the document.Please, note that:
The DOMNodeRemoved has been kept to cover the case where the element is removed from a currently detached parent.