Skip to content

Fix destroy:composer event not being fired #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrhames wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix destroy:composer event not being fired #307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2d4b4c
addEventListener only accept a string as type
jrhames Feb 23, 2016
7b49b86
DOMNodeRemoved is not fired if parent element is removed
jrhames Feb 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/views/composer.observe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,8 @@
this.focusState = this.getValue(false, false);

// --------- destroy:composer event ---------
container.addEventListener(["DOMNodeRemoved"], handleDomNodeRemoved.bind(this), false);
container.addEventListener("DOMNodeRemoved", handleDomNodeRemoved.bind(this), false);
container.addEventListener("DOMNodeRemovedFromDocument", handleDomNodeRemoved.bind(this), false);

// DOMNodeRemoved event is not supported in IE 8
// TODO: try to figure out a polyfill style fix, so it could be transferred to polyfills and removed if ie8 is not needed
Expand Down