feat(shell): align native menus, activation, startup readiness, and macOS smoke#175
Merged
Merged
Conversation
6 tasks
…ess-stop-recovery
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmd+Q, and complete About metadata.zh-CNand x64/English. It verifies bundle metadata/architecture, WebView IPC/CSP readiness, localized menus, minimized/hidden single-instance recovery,Cmd+W,Cmd+Q, and the native Quit item without exposing release signing or notarization secrets.Validation
npm run check— passnpm run lint— passnpm test— passnpm run build— passcargo clippy --manifest-path src-tauri/Cargo.toml --workspace --all-targets -- -D warnings— passcargo test --manifest-path src-tauri/Cargo.toml --workspace— passactionlint .github/workflows/mac-packaged-smoke.yml— passbash -n scripts/macos-packaged-smoke.sh— passnpm run tauri build -- --config src-tauri/tauri.smoke.conf.json --bundles app --target aarch64-apple-darwin --no-sign --ci— passzh-CNpackaged lifecycle smoke — pass: bundle → locale/menu → IPC/CSP → single-instance restore → close →Cmd+Q/menu Quitcodex review --base origin/main— pass: no P1/P2 and no findingsgit diff --check origin/main...HEAD— passDeployment notes
No runtime migration is required. The new macOS workflow is PR-only and unsigned, uses an isolated bundle identifier/data directory, and does not read release signing or notarization secrets. Allow both arm64/
zh-CNand x64/English matrix jobs to finish before merge; signed/notarized packaging remains release-only.Closes #169