Fix C# parameter modifier type references - #4924
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
out,ref,in,params,this, andscopedonly when they occur in parameter/argument modifier positionsRoot cause
Multiline continuation lines could fall through to the simple declaration type parser, whose leading-token scan did not recognize parameter modifiers. The initial bounded fix also stopped after top-level comma handling, while nested invocation/lambda arguments and final
)-closing fragments required position-aware scanning across the full line.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --no-build --filter FullyQualifiedName~Issue4832 -p:UseSharedCompilation=false— passed on net8.0 and net9.0 (2 tests each)dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false— passed with 0 warnings and 0 errorsdotnet test CodeIndex.sln -c Release --no-build -p:UseSharedCompilation=false— passed: net8.0 10,511 passed / 7 skipped / 0 failed; net9.0 10,038 passed / 419 skipped / 0 faileddotnet run --project tools/CodeIndex.Changelog -- check— passed (6 fragments validated)outtype_referencerows: 0Documentation and changelog
DEVELOPER_GUIDE.mdandTESTING_GUIDE.mdchangelog.d/unreleased/4832.fixed.mdAGENTS.md,CLAUDE.md, orAGENT_GUIDE.mdFixes #4832