Skip to content

chore: ignore wbfy test fixtures#739

Merged
exKAZUu merged 1 commit intomainfrom
chore/ignore-wbfy-test-fixtures
May 1, 2026
Merged

chore: ignore wbfy test fixtures#739
exKAZUu merged 1 commit intomainfrom
chore/ignore-wbfy-test-fixtures

Conversation

@exKAZUu
Copy link
Copy Markdown
Member

@exKAZUu exKAZUu commented May 1, 2026

Summary

  • Ignore packages/wbfy/test-fixtures/ so local/generated fixture content stays out of commits.
  • Normalize the nearby Icon ignore entry formatting.

Why

  • Fixture directories can be generated or changed during local validation, and they should not appear as source changes.
  • Keeping the ignore file formatted avoids future formatter churn around the same block.

Testing

  • yarn verify

Notes

  • yarn verify completed successfully and reported existing packages/wbfy lint warnings, but no errors.

Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu exKAZUu enabled auto-merge (squash) May 1, 2026 22:44
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request manually updates the .gitignore file in packages/wbfy to ignore test-fixtures/ and adds a newline. Feedback indicates that these manual changes should instead be implemented within the generator logic to prevent them from being overwritten, to reduce redundancy across packages, and to avoid breaking the specific ignore rule for macOS Icon files.

Comment thread packages/wbfy/.gitignore
Comment on lines +67 to +68
Icon

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This manual change is problematic for several reasons:\n\n1. Generated Section: This part of the file is managed by wbfy. Manual edits here will be overwritten the next time the tool is run.\n2. Potential Regression: The comment on line 66 explicitly states that Icon must end with two \\r characters. The diff indicates that line 67 was replaced; if your editor stripped these trailing characters during "normalization," the ignore rule for macOS system Icon files will be broken.\n3. Formatting Conflict: Adding a second empty line contradicts the normalization logic found in src/utils/ignoreFileUtil.ts (line 32), which collapses multiple newlines into one.\n\nTo resolve the "formatter churn" mentioned in the PR description, please update the generator logic in src/generators/gitignore.ts instead of manually editing this file.

Comment thread packages/wbfy/.gitignore
@@ -1,5 +1,6 @@
# Project-specific settings (head)

test-fixtures/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of manually adding test-fixtures/ to the "head" section of this package's .gitignore, consider adding it to the commonContent list in src/generators/gitignore.ts. Since these directories are generated during validation (as noted in the PR description), making this a default ignore rule in the generator would benefit all packages managed by wbfy and adhere to the repository's goal of reducing redundancy (Rule 6).

References
  1. Simplify code as much as possible to eliminate redundancy. (link)

@exKAZUu exKAZUu merged commit 6bd83b1 into main May 1, 2026
7 checks passed
@exKAZUu exKAZUu deleted the chore/ignore-wbfy-test-fixtures branch May 1, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant