Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
There was a problem hiding this comment.
Code Review
This pull request manually updates the .gitignore file in packages/wbfy to ignore test-fixtures/ and adds a newline. Feedback indicates that these manual changes should instead be implemented within the generator logic to prevent them from being overwritten, to reduce redundancy across packages, and to avoid breaking the specific ignore rule for macOS Icon files.
| Icon | ||
|
|
There was a problem hiding this comment.
This manual change is problematic for several reasons:\n\n1. Generated Section: This part of the file is managed by wbfy. Manual edits here will be overwritten the next time the tool is run.\n2. Potential Regression: The comment on line 66 explicitly states that Icon must end with two \\r characters. The diff indicates that line 67 was replaced; if your editor stripped these trailing characters during "normalization," the ignore rule for macOS system Icon files will be broken.\n3. Formatting Conflict: Adding a second empty line contradicts the normalization logic found in src/utils/ignoreFileUtil.ts (line 32), which collapses multiple newlines into one.\n\nTo resolve the "formatter churn" mentioned in the PR description, please update the generator logic in src/generators/gitignore.ts instead of manually editing this file.
| @@ -1,5 +1,6 @@ | |||
| # Project-specific settings (head) | |||
|
|
|||
| test-fixtures/ | |||
There was a problem hiding this comment.
Instead of manually adding test-fixtures/ to the "head" section of this package's .gitignore, consider adding it to the commonContent list in src/generators/gitignore.ts. Since these directories are generated during validation (as noted in the PR description), making this a default ignore rule in the generator would benefit all packages managed by wbfy and adhere to the repository's goal of reducing redundancy (Rule 6).
References
- Simplify code as much as possible to eliminate redundancy. (link)
Summary
packages/wbfy/test-fixtures/so local/generated fixture content stays out of commits.Iconignore entry formatting.Why
Testing
yarn verifyNotes
yarn verifycompleted successfully and reported existingpackages/wbfylint warnings, but no errors.