Skip to content

chore: ignore wbfy test fixtures #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exKAZUu merged 1 commit into from
May 1, 2026
Merged

chore: ignore wbfy test fixtures #739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/wbfy/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Project-specific settings (head)

test-fixtures/
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of manually adding test-fixtures/ to the "head" section of this package's .gitignore, consider adding it to the commonContent list in src/generators/gitignore.ts. Since these directories are generated during validation (as noted in the PR description), making this a default ignore rule in the generator would benefit all packages managed by wbfy and adhere to the repository's goal of reducing redundancy (Rule 6).

References
  1. Simplify code as much as possible to eliminate redundancy. (link)


# Generated by @willbooster/willboosterify

Expand Down Expand Up @@ -63,7 +64,8 @@ $RECYCLE.BIN/
.LSOverride

# Icon must end with two \r
Icon
Icon

Comment on lines +67 to +68
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This manual change is problematic for several reasons:\n\n1. Generated Section: This part of the file is managed by wbfy. Manual edits here will be overwritten the next time the tool is run.\n2. Potential Regression: The comment on line 66 explicitly states that Icon must end with two \\r characters. The diff indicates that line 67 was replaced; if your editor stripped these trailing characters during "normalization," the ignore rule for macOS system Icon files will be broken.\n3. Formatting Conflict: Adding a second empty line contradicts the normalization logic found in src/utils/ignoreFileUtil.ts (line 32), which collapses multiple newlines into one.\n\nTo resolve the "formatter churn" mentioned in the PR description, please update the generator logic in src/generators/gitignore.ts instead of manually editing this file.


# Thumbnails
._*
Expand Down
Loading