Skip to content

RTL: Fix block inserter popver in RTL mode by telling RTLCSS to ignore the relevent props#7429

Merged
aduth merged 1 commit intoWordPress:masterfrom
yoavf:update/editor-inserter-rtl
Jun 21, 2018
Merged

RTL: Fix block inserter popver in RTL mode by telling RTLCSS to ignore the relevent props#7429
aduth merged 1 commit intoWordPress:masterfrom
yoavf:update/editor-inserter-rtl

Conversation

@yoavf
Copy link
Copy Markdown
Contributor

@yoavf yoavf commented Jun 21, 2018

Description

Prevent RTLCSS from reversing specific CSS rules related to left/right alignment of the popover component
Similar to #3911

Screenshots

Before:
screen shot 2018-06-21 at 14 19 51

After:
screen shot 2018-06-21 at 14 19 16

Types of changes

CSS comments to prevent automatic flipping of CSS properties.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@mtias mtias added Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended labels Jun 21, 2018
@mtias mtias added this to the 3.1 milestone Jun 21, 2018
Copy link
Copy Markdown
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aduth aduth merged commit 56254e4 into WordPress:master Jun 21, 2018
@yoavf yoavf deleted the update/editor-inserter-rtl branch June 21, 2018 17:20
@mtias mtias modified the milestones: 3.1, 3.2 Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants