Skip to content

fix: repair issue 3670 current-dev regressions - #3681

Merged
Yeachan-Heo merged 7 commits into
devfrom
repair/3670-current-dev
Jul 31, 2026
Merged

fix: repair issue 3670 current-dev regressions#3681
Yeachan-Heo merged 7 commits into
devfrom
repair/3670-current-dev

Conversation

@Yeachan-Heo

Copy link
Copy Markdown
Owner

Summary

  • suppress staged async completion after poll acknowledgement using generation-aware stale filtering
  • freeze detached fork-context seeds across allocated and caller task identities
  • refresh deterministic Anthropic cache evidence with exact source blob/SHA provenance

Verification

  • bun test packages/coding-agent/test/async-yield-queue.test.ts packages/coding-agent/test/session/yield-queue.test.ts packages/coding-agent/test/task-fork-context.test.ts packages/coding-agent/test/task/fork-context-advisory.test.ts packages/coding-agent/test/task/fork-context-seed.test.ts packages/ai/test/anthropic-cache-eval.integration.test.ts packages/ai/test/anthropic-cache.test.ts (77 pass)
  • bun --cwd=packages/coding-agent run check:types
  • bun --cwd=packages/ai run check:types

Scope

Follow-up

  • RALPLAN detached planner session-resolution failure recorded as a GJC product-gap ledger entry.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Yeachan-Heo
Yeachan-Heo force-pushed the repair/3670-current-dev branch from 95e8f8f to 8b07211 Compare July 31, 2026 17:39
@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

Hostile intake: REQUEST_CHANGES / merge blocked

Exact head fd5624b0ffcf2472b57b3516954df8accdb2fcb1; base 8846d0925b598ead06d56979f0d2696ed5bcc8de is an ancestor of current dev, and the product diff is narrowly scoped to the #3670 coding-agent/AI repair surface. Focused exact-head verification passes 28 tests / 133 assertions across async yield queue, fork context, and Anthropic cache evidence; git diff --check passes.

However, this is an owner-controlled internal repair PR, not a contributor PR, and exact required CI is not terminal: Telegram generation guard and affected native-build remain pending. The PR must not merge until exact-head CI is terminal green, the owner’s review artifact is authoritative, and the separate #3669 Codex SSE repair remains separate. Central review does not mutate or merge the owner branch.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

Review correction: integration hold, not product REQUEST_CHANGES

Exact head 9711458b0b797e1a2545a4b4b88e2bffee298949 has 20 green product checks. The remaining evidence/aggregate failure is inherited from the Telegram generation-guard integration gate and is downstream of that root; it is not a product-code failure in this PR. Therefore no product REQUEST_CHANGES disposition is assigned.

The PR remains on integration hold pending the assigned #3679 Telegram successor/guard repair. Once #3679 provides the exact current integration state, this PR requires a fresh exact-head check census; no rerun or contributor mutation was performed here.


[repo owner's gaebal-gajae (clawdbot) 🦞]

gaebal-gajae added 7 commits July 31, 2026 18:10
Poll acknowledgement can race with a completion already staged in the yield queue. Carry the immutable job generation into the queue stale check so acknowledgement removes that completion without affecting a later generation.

Issue: #3670

Tested: bun test packages/coding-agent/test/async-yield-queue.test.ts packages/coding-agent/test/session/yield-queue.test.ts
Freeze the inherited seed before detached dispatch and retain it under both the allocated and caller task identities so compatibility callbacks cannot rebuild context from a later parent snapshot.

Issue: #3670

Tested: bun test packages/coding-agent/test/task-fork-context.test.ts packages/coding-agent/test/task/fork-context-advisory.test.ts packages/coding-agent/test/task/fork-context-seed.test.ts
Refresh the deterministic cache evaluation artifact with the exact provider source blob and SHA-256 proven by the fixture test.

Issue: #3670

Tested: bun test packages/ai/test/anthropic-cache-eval.integration.test.ts
Record the exact focused regression suite, package typechecks, scoped files, and atomic commit identities for the issue 3670 repair.

Issue: #3670

Tested: bun test packages/coding-agent/test/async-yield-queue.test.ts packages/coding-agent/test/session/yield-queue.test.ts packages/coding-agent/test/task-fork-context.test.ts packages/coding-agent/test/task/fork-context-advisory.test.ts packages/coding-agent/test/task/fork-context-seed.test.ts packages/ai/test/anthropic-cache-eval.integration.test.ts packages/ai/test/anthropic-cache.test.ts
Rename the cache evaluation artifact away from the unrelated architecture issue and bind the fixture test and focused evidence to the issue-specific provenance file.

Issue: #3670

Tested: bun test packages/ai/test/anthropic-cache-eval.integration.test.ts; bun test focused Issue #3670 suites; package typechecks
Bind the focused evidence artifact to the current rebased head and full signed atomic commit set.

Issue: #3670

Tested: focused Issue #3670 regression suite and package typechecks
Bind the focused evidence receipt to the post-3679 exact current-dev head.

Issue: #3670

Tested: focused Issue #3670 regression suite and package typechecks
@Yeachan-Heo
Yeachan-Heo force-pushed the repair/3670-current-dev branch from 9711458 to 3da7b40 Compare July 31, 2026 18:10
@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

Terminal hostile disposition: MERGE_READY — integration hold remains

Exact head 3da7b40 is current against dev@cebd783a and the product checks are terminal green: 22/22 green, 0 red, 0 pending. Hostile review finds no P0/P1 in the #3670 coding-agent/AI product diff. The async staged-completion generation metadata, fork-context seed preservation, and immutable Anthropic fixture provenance are scoped to the owner lane and retain separate #3669 evidence requirements.

The earlier evidence failure is inherited Telegram guard integration and downstream, not a product failure in this PR. Merge authorization is therefore conditional on the assigned #3679 Telegram/guard owner resolving the integration root; this PR must not be merged ahead of that dependency. No contributor branch was mutated and no workflow was rerun.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo Yeachan-Heo left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hostile terminal review for #3670: MERGE_READY. Scope is contained to async delivery acknowledgement suppression, detached fork-context seed freezing, and Anthropic cache provenance. The unrelated architecture-2383 artifact was removed and replaced by issue-scoped evidence. Current PR base is cebd783; prior inherited-dev red was attributed to #3679 Telegram guard authority, not REQUEST_CHANGES on product logic. Focused tests and package typechecks passed; PR CI run 30654139692 was green. No guard-manifest mutation is present.

@Yeachan-Heo
Yeachan-Heo merged commit 699a634 into dev Jul 31, 2026
29 checks passed
@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

Post-merge correction: MERGE_READY was satisfied

Correction to the earlier integration-hold wording: PR #3681’s exact head 3da7b40 was technically MERGE_READY with 22/22 green product checks and no P0/P1 findings. The Telegram integration dependency had already been resolved by #3679 before the merge. PR #3681 subsequently merged into dev as commit 699a634.

The prior comment’s integration-hold language is superseded for historical accuracy; the technical hostile-review findings and MERGE_READY disposition remain valid. No source or workflow changes are implied by this correction.


[repo owner's gaebal-gajae (clawdbot) 🦞]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant