fix: repair issue 3670 current-dev regressions - #3681
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
95e8f8f to
8b07211
Compare
|
Hostile intake: REQUEST_CHANGES / merge blocked Exact head However, this is an owner-controlled internal repair PR, not a contributor PR, and exact required CI is not terminal: Telegram generation guard and affected native-build remain pending. The PR must not merge until exact-head CI is terminal green, the owner’s review artifact is authoritative, and the separate #3669 Codex SSE repair remains separate. Central review does not mutate or merge the owner branch. — |
c4f97a8 to
650e1d4
Compare
|
Review correction: integration hold, not product REQUEST_CHANGES Exact head The PR remains on integration hold pending the assigned #3679 Telegram successor/guard repair. Once #3679 provides the exact current integration state, this PR requires a fresh exact-head check census; no rerun or contributor mutation was performed here. — |
Poll acknowledgement can race with a completion already staged in the yield queue. Carry the immutable job generation into the queue stale check so acknowledgement removes that completion without affecting a later generation. Issue: #3670 Tested: bun test packages/coding-agent/test/async-yield-queue.test.ts packages/coding-agent/test/session/yield-queue.test.ts
Freeze the inherited seed before detached dispatch and retain it under both the allocated and caller task identities so compatibility callbacks cannot rebuild context from a later parent snapshot. Issue: #3670 Tested: bun test packages/coding-agent/test/task-fork-context.test.ts packages/coding-agent/test/task/fork-context-advisory.test.ts packages/coding-agent/test/task/fork-context-seed.test.ts
Refresh the deterministic cache evaluation artifact with the exact provider source blob and SHA-256 proven by the fixture test. Issue: #3670 Tested: bun test packages/ai/test/anthropic-cache-eval.integration.test.ts
Record the exact focused regression suite, package typechecks, scoped files, and atomic commit identities for the issue 3670 repair. Issue: #3670 Tested: bun test packages/coding-agent/test/async-yield-queue.test.ts packages/coding-agent/test/session/yield-queue.test.ts packages/coding-agent/test/task-fork-context.test.ts packages/coding-agent/test/task/fork-context-advisory.test.ts packages/coding-agent/test/task/fork-context-seed.test.ts packages/ai/test/anthropic-cache-eval.integration.test.ts packages/ai/test/anthropic-cache.test.ts
Rename the cache evaluation artifact away from the unrelated architecture issue and bind the fixture test and focused evidence to the issue-specific provenance file. Issue: #3670 Tested: bun test packages/ai/test/anthropic-cache-eval.integration.test.ts; bun test focused Issue #3670 suites; package typechecks
9711458 to
3da7b40
Compare
|
Terminal hostile disposition: MERGE_READY — integration hold remains Exact head The earlier evidence failure is inherited Telegram guard integration and downstream, not a product failure in this PR. Merge authorization is therefore conditional on the assigned #3679 Telegram/guard owner resolving the integration root; this PR must not be merged ahead of that dependency. No contributor branch was mutated and no workflow was rerun. — |
Yeachan-Heo
left a comment
There was a problem hiding this comment.
Hostile terminal review for #3670: MERGE_READY. Scope is contained to async delivery acknowledgement suppression, detached fork-context seed freezing, and Anthropic cache provenance. The unrelated architecture-2383 artifact was removed and replaced by issue-scoped evidence. Current PR base is cebd783; prior inherited-dev red was attributed to #3679 Telegram guard authority, not REQUEST_CHANGES on product logic. Focused tests and package typechecks passed; PR CI run 30654139692 was green. No guard-manifest mutation is present.
|
Post-merge correction: MERGE_READY was satisfied Correction to the earlier integration-hold wording: PR #3681’s exact head The prior comment’s integration-hold language is superseded for historical accuracy; the technical hostile-review findings and MERGE_READY disposition remain valid. No source or workflow changes are implied by this correction. — |
Summary
Verification
bun test packages/coding-agent/test/async-yield-queue.test.ts packages/coding-agent/test/session/yield-queue.test.ts packages/coding-agent/test/task-fork-context.test.ts packages/coding-agent/test/task/fork-context-advisory.test.ts packages/coding-agent/test/task/fork-context-seed.test.ts packages/ai/test/anthropic-cache-eval.integration.test.ts packages/ai/test/anthropic-cache.test.ts(77 pass)bun --cwd=packages/coding-agent run check:typesbun --cwd=packages/ai run check:typesScope
Follow-up