feat(sdk): add active provider discovery query - #3694
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aedf596fb9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aedf596 to
96fc8f0
Compare
|
Read-only intake: existing-owner review candidate Contributor intake is attributable to Exact head — |
96fc8f0 to
58368b3
Compare
|
Rebased the single Q29 commit onto current |
Yeachan-Heo
left a comment
Yeachan-Heo
left a comment
There was a problem hiding this comment.
T1 review complete after exact terminal CI verification.
- Head 58368b3 is one commit ahead of dev with no base lag.
- 35 reported checks are terminal; 29 succeeded and 6 are explicitly skipped by the affected-path matrix. No check is pending or failed.
- Reviewed the Q29 SDK surface, provider-activity/evidence tracking, query-bearing OpenAI routing, pagination/error handling, generated inventory, exports, and focused regressions.
- No blocking correctness or security findings. Secret-bearing resolver failures are reduced to the fixed internal error, and Q29 is prohibited on notification adapters.
Ownership remains with the existing SDK/provider lane; no source mutation, merge, or issue creation performed.
58368b3 to
e99b35d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e99b35de94
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e99b35d to
7e878db
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e878dbe38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2956a8b to
10f13a8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10f13a83bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cb2e9dd to
1677734
Compare
Superseded by exact head cb2e9dd; predecessor approval and CI evidence are invalid for this head.
Yeachan-Heo
left a comment
Yeachan-Heo
left a comment
There was a problem hiding this comment.
Signed: Yeachan-Heo / fresh-context hostile review
GJC verdict: REQUEST_CHANGES exact head cb2e9dd. The prior approval for 58368b3 was dismissed and is not evidence for this head.
Exact-head CI is terminal but not green: 18 terminal checks, 8 success, 5 skipped, 3 cancelled, 2 failures, 0 non-terminal. Failed checks are Affected path validation and Affected path validation / evidence producer; the evidence producer failed because the required native build did not succeed after the native-build job was cancelled.
Hostile review of the rebased exact-head scope found the Q29 implementation still limited to the documented SDK/provider-discovery surface: exact provider IDs, non-secret DTO projection, credential/endpoint evidence fencing, query-bearing OpenAI routing, retained pagination, generated inventory/export updates, and focused regressions. No new source-level blocker was identified in the rebase delta. However, the PR body still says it was rebuilt on dev 58c1b16 even though the exact base is dev 0cc1536; that admission evidence is stale and must be reconciled.
Acceptance is blocked until this exact head has a successful terminal GJC CI verdict and the stale base/verification statement is corrected. Do not merge from the predecessor review, predecessor CI, or the embedded old verdict.
1677734 to
b6624c3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6624c35bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9ff4f12 to
8f5d4f7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f5d4f740c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
277d8c6 to
377e5d9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 377e5d98af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
377e5d9 to
6afdf5e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef0eb12e89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ef0eb12 to
ec12721
Compare
ec12721 to
48f54ea
Compare
48f54ea to
3327ab9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3327ab90f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fd70566 to
2adb747
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2adb747217
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2adb747 to
261f3b0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 261f3b0f6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
261f3b0 to
384bc12
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 384bc12a2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2a3937d to
b2dfbe0
Compare
Expose Q29 providers.list/active with non-secret descriptors, retained query snapshots, and credential-bound discovery eligibility.
|
VERDICT: REQUEST_CHANGES Exact reviewed head: b2dfbe0 Hostile-review evidence:
Blocking CI evidence:
Resolve the affected-path evidence-producer failure, stop superseding the reviewed head, and rerun terminal CI for the settled head. No merge performed. — |
|
The reviewed |
|
VERDICT: OWNER_CONFIRMATION_REQUIRED Exact reviewed head: 07a25a2 Fresh hostile exact-head review:
Control-plane evidence gap:
OWNER_CONFIRMATION_REQUIRED is limited to that receipt/control-plane gap; no merge, push, rebase, commit, or product mutation was performed. — |
|
VERDICT: MERGE_READY Fresh read-only hostile review of exact head 07a25a2 against base 3381442. Evidence:
No contributor repair is requested. Do not merge automatically. — |
|
POST-MERGE DOGFOOD COMPLETE Verified merged tree at merge commit a8757cb (PR #3694, merged to dev from exact reviewed head 07a25a2). Evidence:
No release, tag, publish, or additional merge action was performed. — |
|
POST-MERGE CI DIAGNOSIS — exact attribution Merge commit: a8757cb Exact failure:
Attribution: this is a PR #3694 regression in the shared adapter-parity contract, not an unrelated runtime failure. PR #3694 adds the six Q29 adapter rows Comparison with prior shard findings:
No repository mutation, commit, merge, release, or tag action was performed by this diagnosis. — |
2 participants
Summary
Adds Q29, the public SDK query
providers.list/active, rebased on currentdev(c3637684).Public contract
{ provider, connectionKind }.Eligibility and endpoint correctness
Discovery-only providers are returned only with current credential and endpoint-bound discovery evidence. The implementation binds each registry's discovery/cache result to its selected credential, fences stale overlapping refreshes before merging results or publishing the shared discovery cache, revalidates completed configured and descriptor results immediately before aggregate merge, accepts Xiaomi Token Plan’s credential-derived endpoint only when no explicit endpoint overrides it, requires successful current credentialless provenance for optional-auth fallback, recognizes descriptor-declared unauthenticated local providers only after fresh descriptor evidence, canonicalizes implicit local root endpoints before eligibility comparison, invalidates eligibility when configured credentials or implicit-provider endpoints change, isolates provider-local credential refresh failures, keeps unresolved command-backed credentials inactive, scopes command resolver cache entries by credential configuration generation, and fingerprints command-backed credential evidence for invalidation.
For configured OpenAI-compatible descriptor discovery, LM Studio discovery, and the OpenAI Completions/Responses transports, discovery and model identity retain the effective endpoint while requests construct the path before ordered query entries. This covers descriptor
/models, LM Studio/v1/models, Completions/chat/completions, and Responses/responses, including repeated query parameters, configured query ordering before Azure defaults, query values ending in/, retries, query-free durable model-cache rows, and redacted diagnostics/request dumps.Scope boundaries
Included: Q29 protocol/host/export plumbing, provider-eligibility evidence required by that contract (including existing descriptor-declared unauthenticated local providers), the minimal shared auth and OpenAI transport support for that evidence, generated SDK inventory/docs, and focused regressions.
Excluded: unrelated lifecycle, ACP, native shell, resource, profile, read-tool, and settings behavior changes. Existing provider families that are not changed by this PR are not refactored opportunistically.
Verification
bun test packages/coding-agent/test/sdk-operation-inventory.test.ts packages/coding-agent/test/model-registry.test.ts packages/coding-agent/test/sdk-q29-active-providers.test.ts packages/coding-agent/test/sdk-query-pagination.test.ts packages/coding-agent/test/sdk-operation-matrix.test.ts packages/coding-agent/test/sdk-host-wiring.test.ts packages/coding-agent/test/sdk-package-exports.test.ts packages/coding-agent/test/resolve-config-value.test.ts— 363 passbun test packages/ai/test/auth-storage-refresh-skew.test.ts packages/ai/test/openai-responses-system-prompt.test.ts packages/ai/test/openai-completions-compat.test.ts packages/ai/test/provider-fetch-override.test.ts— 67 passbun --cwd=packages/ai run checkbun --cwd=packages/coding-agent run checkgit diff --check