Skip to content

Gx games fixes #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opera-duanei merged 3 commits into from
May 6, 2026
Merged

Gx games fixes #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25b1300
Drop interactive prompts from gxgames meta
opera-duanei May 6, 2026
21d0352
Treat gxgames meta no_changes response as success
opera-duanei May 6, 2026
13a8478
Document 16:9 image requirement
opera-duanei May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/commands/gxgames/command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,15 @@ const gxgamesMetaCommand = buildCommand({
cover: {
kind: "parsed",
parse: String,
brief: "Path to a 16:9 cover image (PNG or JPG)",
brief:
"Path to a 16:9 cover image, exact ratio required (e.g. 1920x1080 PNG/JPG)",
optional: true,
},
graphic: {
kind: "parsed",
parse: String,
brief: "Path to a screenshot or graphic to upload (PNG or JPG)",
brief:
"Path to a 16:9 screenshot/graphic, exact ratio required (e.g. 1920x1080 PNG/JPG)",
optional: true,
},
},
Expand Down
162 changes: 34 additions & 128 deletions src/commands/gxgames/commands/meta-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,38 +15,17 @@
*/

import type { Context } from "~/context";
import * as p from "@clack/prompts";
import { KnownError } from "~/error";

import { LinkStorage } from "../api";
import { createAuthManager } from "../auth";
import { getApiClient } from "../api";
import type {
GameDevUpdateGameRequest,
GameDevUpdateGameRequestAgeRatingEnum,
GameDevUpdateGameRequestPlatformsEnum,
} from "../api/generated/data-contracts";

const AGE_RATING_OPTIONS: {
value: GameDevUpdateGameRequestAgeRatingEnum;
label: string;
}[] = [
{ value: "NOT_SET", label: "Not set" },
{ value: "EVERYONE", label: "Everyone" },
{ value: "CHILDREN", label: "Children" },
{ value: "EARLY_TEENS", label: "Early teens (10+)" },
{ value: "TEENS", label: "Teens (13+)" },
{ value: "ADULTS", label: "Adults (18+)" },
{ value: "MATURE", label: "Mature (21+)" },
];

const PLATFORM_OPTIONS: {
value: GameDevUpdateGameRequestPlatformsEnum;
label: string;
}[] = [
{ value: "DESKTOP", label: "Desktop" },
{ value: "MOBILE", label: "Mobile" },
];

interface MetaFlags {
title?: string;
agerating?: string;
Expand All @@ -67,107 +46,48 @@ export default async function (this: Context, flags: MetaFlags): Promise<void> {
const game = gameRes.data;

// --- Metadata ---
// Per field: flag overrides server value; otherwise keep server value as-is.

let title: string;
if (flags.title != null) {
title = flags.title;
} else {
const v = await p.text({ message: "Title", initialValue: game.title });
if (p.isCancel(v)) {
return process.exit(0);
}
title = v;
}

let description: string | undefined;
if (flags.description != null) {
description = flags.description || undefined;
} else {
const v = await p.text({
message: "Short description (leave empty to skip)",
initialValue: game.shortDescription ?? "",
});
if (p.isCancel(v)) {
return process.exit(0);
}
description = v || undefined;
}

let ageRating: GameDevUpdateGameRequestAgeRatingEnum;
if (flags.agerating != null) {
ageRating =
flags.agerating.toUpperCase() as GameDevUpdateGameRequestAgeRatingEnum;
} else {
const v = await p.select({
message: "Age rating",
options: AGE_RATING_OPTIONS,
initialValue: game.ageRating as
const updateLog = this.makeTaskLogger("Updating metadata");
const updateData: GameDevUpdateGameRequest = {
title: flags.title ?? game.title,
shortDescription: flags.description ?? game.shortDescription,
ageRating:
(flags.agerating?.toUpperCase() as
| GameDevUpdateGameRequestAgeRatingEnum
| undefined,
});
if (p.isCancel(v)) {
return process.exit(0);
| undefined) ??
(game.ageRating as GameDevUpdateGameRequestAgeRatingEnum),
platforms:
flags.platforms
?.split(",")
.map(
(s) =>
s.trim().toUpperCase() as GameDevUpdateGameRequestPlatformsEnum,
)
.filter(Boolean) ??
(game.platforms as GameDevUpdateGameRequestPlatformsEnum[]),
};
const updateRes = await api.updateGame(link.gameId, updateData);
if (!updateRes.success) {
if (updateRes.errors.every((e) => e.code === "no_changes")) {
updateLog.success("Metadata unchanged");
} else {
updateLog.error("Failed");
throw new KnownError(updateRes.errors);
}
ageRating = v;
}

let platforms: GameDevUpdateGameRequestPlatformsEnum[];
if (flags.platforms != null) {
platforms = flags.platforms
.split(",")
.map(
(s) => s.trim().toUpperCase() as GameDevUpdateGameRequestPlatformsEnum,
)
.filter(Boolean);
} else {
const v = await p.multiselect({
message: "Platforms",
options: PLATFORM_OPTIONS,
initialValues: game.platforms as GameDevUpdateGameRequestPlatformsEnum[],
required: false,
});
if (p.isCancel(v)) {
return process.exit(0);
}
platforms = v;
}

const updateLog = this.makeTaskLogger("Updating metadata");
const updateRes = await api.updateGame(link.gameId, {
title,
shortDescription: description,
ageRating,
platforms,
});
if (!updateRes.success) {
updateLog.error("Failed");
throw new KnownError(updateRes.errors);
updateLog.success("Metadata updated");
}
updateLog.success("Metadata updated");

// --- Cover ---

let coverPath: string | undefined;
if (flags.cover != null) {
coverPath = flags.cover || undefined;
} else {
const v = await p.text({
message: "Cover image path (16:9 PNG/JPG — leave empty to skip)",
placeholder: "/path/to/cover.png",
});
if (p.isCancel(v)) {
return process.exit(0);
}
coverPath = v || undefined;
}

if (coverPath) {
if (flags.cover) {
const coverLog = this.makeTaskLogger("Uploading cover");
const fileBuffer = await this.fs.readFile(coverPath);
const fileBuffer = await this.fs.readFile(flags.cover);
const coverRes = await api.uploadCover(
link.gameId,
{ aspectRatio: "16:9", coverType: "IMAGE" },
{ file: new File([fileBuffer], this.path.basename(coverPath)) },
{ file: new File([fileBuffer], this.path.basename(flags.cover)) },
);
if (!coverRes.success) {
coverLog.error("Failed");
Expand All @@ -178,25 +98,11 @@ export default async function (this: Context, flags: MetaFlags): Promise<void> {

// --- Graphic ---

let graphicPath: string | undefined;
if (flags.graphic != null) {
graphicPath = flags.graphic || undefined;
} else {
const v = await p.text({
message: "Screenshot/graphic path (PNG/JPG — leave empty to skip)",
placeholder: "/path/to/screenshot.png",
});
if (p.isCancel(v)) {
return process.exit(0);
}
graphicPath = v || undefined;
}

if (graphicPath) {
if (flags.graphic) {
const graphicLog = this.makeTaskLogger("Uploading graphic");
const fileBuffer = await this.fs.readFile(graphicPath);
const fileBuffer = await this.fs.readFile(flags.graphic);
const graphicRes = await api.uploadGraphic(link.gameId, {
file: new File([fileBuffer], this.path.basename(graphicPath)),
file: new File([fileBuffer], this.path.basename(flags.graphic)),
});
if (!graphicRes.success) {
graphicLog.error("Failed");
Expand Down
Loading