chore(deps): migrate to ZeroAlloc.TestHelpers for AllocationGate#16
Merged
Merged
Conversation
Removes the local samples/.../Internal/AllocationGate.cs and pulls the helper in via the new ZeroAlloc.TestHelpers package (ZeroAlloc-Net/ZeroAlloc.TestHelpers, source-only NuGet at contentFiles/cs/any/ZeroAlloc.TestHelpers/AllocationGate.cs). This consumer's previous local copy was the older/smaller version of the helper - missing AssertBudgetValueTask<T>(...) that Mediator and Authorization had added later. After this migration, the smoke gets the full helper automatically. The smoke does not currently call the ValueTask overload; the capability is just available now. Closes the AllocationGate-copy-drift that motivated the factor-out (ZA.Mediator backlog #10).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the local copy of
samples/.../Internal/AllocationGate.csand replaces it with aPackageReferenceto the newly-publishedZeroAlloc.TestHelpers1.0.0 package.Closes the drift: this repo's local copy was the older/smaller version of the helper - missing
AssertBudgetValueTask<T>(...)that Mediator and Authorization had. After this migration, the smoke gets the full helper. The smoke doesn't currently invoke the ValueTask overload; the capability is just available now.Mirrors PR ZeroAlloc-Net/ZeroAlloc.Mediator#96 + ZeroAlloc-Net/ZeroAlloc.Authorization#27. Final consumer in the rollout for ZA.Mediator backlog #10.
Consumer recipe
Test plan
Local verification (pre-push):