Conversation
|
Merging to
|
Summary of ChangesHello @mdabucse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor documentation issue by correcting the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the repository URL in the README.md to use a specific username instead of a placeholder. While this makes the command work out-of-the-box for cloning the main repository, it could be confusing for users who follow the instructions to fork the repository for using GitHub Actions. My suggestion is to use a more explicit placeholder like YOUR_USERNAME to guide users to clone their own fork, ensuring a smoother setup process for all use cases described in the documentation.
Thanks for the suggestion! The clone URL under "Quick start" is intentionally set to the original repository owner (abhimehro) so users can directly copy-paste and clone the repo. Users who want to use GitHub Actions are separately instructed to fork the repo in the "Configure GitHub Actions" section below, so the distinction is already clear. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@abhimehro |
abhimehro
left a comment
There was a problem hiding this comment.
Hey @mdabucse, thanks for opening this and for the clear write-up on the CI failure!
On the README change:
Gemini's note is worth taking seriously. Using your-username (or YOUR_USERNAME) as a placeholder is the safer pattern, especially since the docs walk contributors through forking first. If someone clones directly from abhimehro:main instead of their fork, they'll hit push permission errors down the line. Want to swap it back to a placeholder with a short note clarifying the fork-first flow?
On the failing check:
You're right, this isn't on you. The copilot-setup-steps workflow uses pull_request, which restricts the token to read-only for fork-based PRs. The createComment() call at line 55 will 403 every time for external contributors. I'll look at migrating it to pull_request_target, or marking it non-required so it doesn't block otherwise clean PRs.
Next steps:
- Swap the clone URL to a placeholder (or add an inline comment pointing contributors to substitute their username)
- I'll handle the workflow fix on my end
Appreciate you flagging the CI issue proactively! That kind of context saves a lot of back and forth.
|
Swapped it back to a placeholder with a short note clarifying the fork-first flow in Pull Request #361 |
#335 I made the changes based on the requirements