Skip to content

Fix README clone URL placeholder, add PR test workflow, standardize uv docs#361

Merged
abhimehro merged 3 commits intomainfrom
copilot/discuss-task-miner-code-quality
Feb 19, 2026
Merged

Fix README clone URL placeholder, add PR test workflow, standardize uv docs#361
abhimehro merged 3 commits intomainfrom
copilot/discuss-task-miner-code-quality

Conversation

Copy link

Copilot AI commented Feb 18, 2026

Several documentation inconsistencies and a missing CI test workflow left contributors with incorrect setup instructions and no automated test gate on PRs.

Changes

README.md

  • Clone URL: Use YOUR_USERNAME placeholder with an explicit "Fork first" note — prevents contributors from accidentally cloning upstream and hitting push permission errors
  • Testing section: Replace pip install pytest... + bare pytest calls with uv run pytest tests/ — consistent with the uv sync-based Quick Start; update test count ~78 → ~95
  • Release process: Same uv run pytest consistency fix

.github/workflows/test.yml (new)

Dedicated test validation workflow — runs pytest on push/pull_request to main using uv to match the documented developer workflow:

- uses: astral-sh/setup-uv@v4
  with:
    python-version: '3.13'
- run: uv sync --all-extras
- run: uv run pytest tests/ -v

Uses the same dependency resolver and lock file that developers use locally. Permissions scoped to contents: read.

Original prompt

This section details on the original issue you should resolve

<issue_title>[Code Quality] Discussion Task Miner - Code Quality Improvement Agent - Issue Group</issue_title>
<issue_description># Discussion Task Miner - Code Quality Improvement Agent

Parent issue for grouping related issues from Discussion Task Miner - Code Quality Improvement Agent.

Sub-issues are automatically linked below (max 64 per parent).

Workflow: Discussion Task Miner - Code Quality Improvement Agent

  • expires on Feb 20, 2026, 3:24 AM UTC</issue_description>

Comments on the Issue (you are @copilot in this section)

Custom agent used: Development Partner
The Development Partner Protocol


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@trunk-io
Copy link

trunk-io bot commented Feb 18, 2026

😎 Merged manually by @abhimehro - details.

@github-actions
Copy link

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

Co-authored-by: abhimehro <84992105+abhimehro@users.noreply.github.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation configuration labels Feb 19, 2026
@github-actions
Copy link

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

Copilot AI changed the title [WIP] Improve code quality for discussion task miner Fix README clone URL placeholder, add PR test workflow, standardize uv docs Feb 19, 2026
Copilot AI requested a review from abhimehro February 19, 2026 00:05
@abhimehro abhimehro marked this pull request as ready for review February 19, 2026 00:06
Copilot AI review requested due to automatic review settings February 19, 2026 00:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses documentation inconsistencies and adds a missing CI test workflow for pull requests. It standardizes testing instructions to use uv run pytest throughout the README, fixes a placeholder clone URL, and introduces automated test validation on PRs.

Changes:

  • Fixed clone URL from placeholder your-username to actual repository owner abhimehro
  • Standardized all testing commands in README.md to use uv run pytest tests/ for consistency with the uv sync-based Quick Start
  • Updated test count reference from ~78 to ~95 tests to reflect current test suite size
  • Added new .github/workflows/test.yml to automatically run tests on push/PR to main branch

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
README.md Fixed clone URL placeholder, standardized all pytest commands to use uv run prefix, updated test count to ~95
.github/workflows/test.yml New CI workflow for automated test execution on push/PR events

Comment on lines +26 to +32
- name: Install dependencies
run: |
pip install -r requirements.txt
pip install pytest pytest-mock pytest-xdist

- name: Run tests
run: pytest tests/ -v
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md was updated to standardize all testing instructions to use uv run pytest tests/ (consistent with the uv sync-based Quick Start), but this workflow still uses pip install + bare pytest. This creates a discrepancy between the documented approach and the CI implementation.

Consider using uv in the workflow to match the documented approach:

  • Install uv (e.g., via astral-sh/setup-uv@v4)
  • Run uv sync to install dependencies including dev dependencies
  • Run uv run pytest tests/ -v

This would ensure CI uses the same dependency resolution and execution environment that developers use locally.

Copilot uses AI. Check for mistakes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 067e532. The workflow now uses astral-sh/setup-uv@v4 + uv sync --all-extras + uv run pytest tests/ -v, matching the developer workflow documented in the README.

Copy link
Owner

@abhimehro abhimehro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H @copilot, please apply changes based on the comments in this thread.

Also, thanks so much for working on these issues!

On the README change:

Gemini's note from another Pull Request Thread (#345) intiated by another contributor is worth taking seriously. Using your-username (or YOUR_USERNAME) as a placeholder is the safer pattern, especially since the docs walk contributors through forking first. If someone clones directly from abhimehro:main instead of their fork, they'll hit push permission errors down the line. Want to swap it back to a placeholder with a short note clarifying the fork-first flow?

On the failing check:

The contributor was right about a Cl workflow, that wasn't on them. The copilot-setup-steps workflow uses pull_request, which restricts the token to read-only for fork-based PRs. The createComment() call at line 55 will 403 every time for external contributors. Could we look at migrating it to pull_request_target, or marking it non-required so it doesn't block otherwise clean PRs.

Next steps: - Swap the clone URL to a placeholder (or add an inline comment pointing contributors to substitute their username) - Handle the workflow fix on my end Appreciate them flagging the CI issue proactively. That kind of context saves a lot of back and forth!

Thanks again for your assistance with these important improvements!

…h fork note

Co-authored-by: abhimehro <84992105+abhimehro@users.noreply.github.com>
Copy link
Author

Copilot AI commented Feb 19, 2026

H @copilot, please apply changes based on the comments in this thread.

Also, thanks so much for working on these iss...

Both changes addressed in 067e532:

  • Clone URL reverted to YOUR_USERNAME placeholder with an inline "Fork first" note to make the fork-before-clone flow explicit
  • test.yml migrated to uv (astral-sh/setup-uv@v4 + uv sync --all-extras + uv run pytest) to match the documented developer workflow

The copilot-setup-steps.yml 403 fix is left for you to handle on your end as mentioned.

@github-actions
Copy link

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

This was referenced Feb 19, 2026
@abhimehro abhimehro merged commit cb62411 into main Feb 19, 2026
27 checks passed
@abhimehro abhimehro deleted the copilot/discuss-task-miner-code-quality branch February 19, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code Quality] Discussion Task Miner - Code Quality Improvement Agent - Issue Group

3 participants