Fix flash timer cancellation, update JSDoc for init and createGameCard#16
Merged
acrosman merged 2 commits intofeature/rabbit-memoryfrom Mar 22, 2026
Merged
Fix flash timer cancellation, update JSDoc for init and createGameCard#16acrosman merged 2 commits intofeature/rabbit-memoryfrom
acrosman merged 2 commits intofeature/rabbit-memoryfrom
Conversation
Merged
…teGameCard Co-authored-by: acrosman <2972053+acrosman@users.noreply.github.com> Agent-Logs-Url: https://github.com/acrosman/BrainSpeedExercises/sessions/c59600aa-4016-4483-8135-bbf8b78db514
Copilot
AI
changed the title
[WIP] Add orbital memory game plugin with rabbit images
Fix flash timer cancellation, update JSDoc for init and createGameCard
Mar 22, 2026
acrosman
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three targeted fixes based on PR review comments on the
orbit-sprite-memoryplugin andgameCardcomponent.Changes
Timer ordering in
submitSelection():clearTimers()was called afterflashBoard(), immediately cancelling the 320 ms cleanup timeout and leaving the success/failure CSS class stuck on the board. MovedclearTimers()beforeflashBoard()so the flash animates and clears correctly.init()JSDoc: Changed@param {HTMLElement}to@param {HTMLElement|null}to match the implementation, which explicitly handles and testsnull/undefinedinput.createGameCard()JSDoc: Added@paramentries forhighestLevel,maxLevel,maxPiggies, andlowestDisplayTime— the four additionalprogressfields the function already renders but had not documented.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.