Skip to content

Fix flash timer cancellation, update JSDoc for init and createGameCard #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acrosman merged 2 commits into from
Mar 22, 2026
Merged

Fix flash timer cancellation, update JSDoc for init and createGameCard #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8681b2
Initial plan
Copilot Mar 22, 2026
d19bbad
Fix timer ordering in submitSelection, update JSDoc for init and crea…
Copilot Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/components/gameCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@
* @param {string} [manifest.thumbnail] - Path to the thumbnail image.
* @param {object} [progress] - Optional progress data for the game.
* @param {number} [progress.highScore] - The player's high score for this game.
* @param {number} [progress.highestLevel] - The highest level reached (0-indexed;
* displayed as level + 1).
* @param {number} [progress.maxLevel] - The maximum level number reached.
* @param {number} [progress.maxPiggies] - The maximum number of piggies collected.
* @param {number} [progress.lowestDisplayTime] - The lowest display time achieved, in milliseconds.
* @returns {HTMLElement} An <article> element representing the game card.
*/
export function createGameCard(manifest, progress) {
Expand Down
4 changes: 2 additions & 2 deletions app/games/orbit-sprite-memory/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,9 +463,9 @@ export function submitSelection() {
announce('Incorrect. Reviewing positions before the next round.');
}

clearTimers();
showRoundReveal(_currentRound);

clearTimers();
_timers.push(setTimeout(() => {
clearRevealSprites();
_timers.push(setTimeout(() => {
Expand Down Expand Up @@ -501,7 +501,7 @@ const name = 'Orbit Sprite Memory';
/**
* Initializes the plugin and wires UI events.
*
* @param {HTMLElement} gameContainer - Injected game container.
* @param {HTMLElement|null} gameContainer - Injected game container.
*/
function init(gameContainer) {
_container = gameContainer;
Expand Down