Skip to content

Improve Tally example against eval audit#3

Closed
adewale wants to merge 1 commit into
pr/eval-quality-harnessfrom
pr/tally-eval-audit
Closed

Improve Tally example against eval audit#3
adewale wants to merge 1 commit into
pr/eval-quality-harnessfrom
pr/tally-eval-audit

Conversation

@adewale

@adewale adewale commented May 25, 2026

Copy link
Copy Markdown
Owner

Stacked on #2. Review this PR against pr/eval-quality-harness, not main.

What

Improves the Tally example using the eval audit from #2 while keeping the same page concept and macrostructure.

Changes are targeted cleanup rather than a redesign:

  • removes the glassmorphism nav surface
  • replaces raw color/shadow literals with token-based values
  • replaces placeholder Acme copy in invoice examples
  • switches away from overused Geist/Geist Mono registers
  • fixes skipped heading levels in the console and footer
  • adds root overflow-x: clip
  • varies equal 3-column grids to avoid the rote card-grid fingerprint
  • removes a layout-property transition
  • keeps the page detector-clean under the audit adapter

Why

The new audit harness should improve real Hallmark examples, not only curated fixtures. Tally was one of the lower-scoring examples in the real-site audit and had mostly high-confidence findings that could be fixed without changing the product direction.

Audit evidence

Before this PR:

examples/tally/  v1 3.59  v2 3.71
findings: type-overused-font, mono-as-shorthand, color-token-discipline,
color-ink-on-ink, visual-glassmorphism, layout-center-everything,
layout-three-col-cards, layout-arbitrary-spacing, layout-skipped-heading,
motion-layout-animation, interaction-placeholder-names, responsive-overflow-clip

After this PR:

examples/tally/  v1 5.00  v2 5.00
findings: —

Testing

node evals/check.mjs
node evals/audit-site.mjs site/examples/tally/index.html

Observed:

PASS v1: 98.5/100   rules 37   fixtures 3
PASS v2: 98.7/100   rules 43   fixtures 5   structure 5.00/5

examples/tally/  v1 5.00  v2 5.00   —

Risk

This touches a visual example, so browser review is still needed. The intent was to keep the existing Tally direction intact and limit the diff to audit-backed cleanup.

@adewale

adewale commented Jun 1, 2026

Copy link
Copy Markdown
Owner Author

Superseded by upstream PRs Nutlope#12-Nutlope#14.

@adewale adewale closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant