fix(copaw): honor model-switch --no-reasoning via enable_thinking=false - #1127
Open
XbaoWu wants to merge 1 commit into
Open
fix(copaw): honor model-switch --no-reasoning via enable_thinking=false#1127XbaoWu wants to merge 1 commit into
XbaoWu wants to merge 1 commit into
Conversation
CoPaw ignored --no-reasoning while OpenClaw set reasoning=false. Persist model-level generate_kwargs on the modern provider store, sync openclaw.json as bridge SoT, and map reasoning:false in the CoPaw bridge.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1126
Summary
model-switchignored--no-reasoning(only loggedreasoning=false) while OpenClaw already persistedreasoning: false.generate_kwargs.extra_body.enable_thinking=falseon the modern CoPaw provider store (providers/custom/agentteams-gateway.json+active_model.json).openclaw.jsonreasoning/ primary as bridge SoT so CoPaw restart / re-bridge does not wipe the setting from an empty local write.openclaw.jsonreasoning: false→ model-level CoPawgenerate_kwargsonly (no shared provider-level flag).Test plan
--no-reasoningwrites model-levelenable_thinking=false; omit flag clears itdocker cpthis script):update-manager-model.sh <model> --no-reasoning→ provider hasenable_thinking=false,openclaw.jsonhasreasoning=false(checked immediately after write)--no-reasoning) restores both sidesreasoning: false→ model-levelgenerate_kwargs(and sibling does not force provider-level)Notes
openclaw.jsonwrite is a separate persistence issue and is not fixed in this PR.