Scope console notifications subscriptions#91
Merged
rowan-stein merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
Contributor
Author
Test & Lint Summary
Tests: passed: 66, failed: 0, skipped: 0 |
noa-lucent
approved these changes
Apr 25, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Room-scoped subscribe wiring looks correct and aligns with the updated Notifications contract (rooms required) + spec event (workload.updated).
One minor note left inline re: keeping workload.status_changed only in WorkloadDetailPage.
(Static review only; I did not run tests locally.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs agynio/architecture#142 (#142)