Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/hooks/useNotifications.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,35 @@ import { notificationsClient } from '@/api/client';
type UseNotificationsOptions = {
events: string[];
invalidateKeys: string[][];
rooms: string[];
enabled?: boolean;
};

export function useNotifications(options: UseNotificationsOptions): void {
const { events, invalidateKeys, enabled = true } = options;
const { events, invalidateKeys, rooms, enabled = true } = options;
const queryClient = useQueryClient();
const eventsRef = useRef(events);
const keysRef = useRef(invalidateKeys);
const roomsRef = useRef(rooms);
const roomsKey = rooms.join('|');
const hasRooms = rooms.length > 0;
eventsRef.current = events;
keysRef.current = invalidateKeys;
roomsRef.current = rooms;

useEffect(() => {
if (!enabled) return;
if (!hasRooms) {
console.error('[useNotifications] rooms are required to subscribe');
return;
}

const controller = new AbortController();
const requestRooms = roomsRef.current;

(async () => {
try {
for await (const response of notificationsClient.subscribe({}, { signal: controller.signal })) {
for await (const response of notificationsClient.subscribe({ rooms: requestRooms }, { signal: controller.signal })) {
const envelope = response.envelope;
if (!envelope) continue;
if (!eventsRef.current.includes(envelope.event)) continue;
Expand All @@ -42,5 +52,5 @@ export function useNotifications(options: UseNotificationsOptions): void {
return () => {
controller.abort();
};
}, [enabled, queryClient]);
}, [enabled, hasRooms, queryClient, roomsKey]);
}
3 changes: 2 additions & 1 deletion src/pages/OrganizationActivityWorkloadsTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ export function OrganizationActivityWorkloadsTab() {
const organizationId = id ?? '';

useNotifications({
events: ['workload.status_changed'],
rooms: organizationId ? [`organization:${organizationId}`] : [],
events: ['workload.updated'],
invalidateKeys: [['workloads', organizationId, 'list']],
enabled: Boolean(organizationId),
});
Expand Down
3 changes: 2 additions & 1 deletion src/pages/OrganizationOverviewTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ export function OrganizationOverviewTab() {
const organizationId = id ?? '';

useNotifications({
events: ['workload.status_changed', 'workload.updated'],
rooms: organizationId ? [`organization:${organizationId}`] : [],
events: ['workload.updated'],
invalidateKeys: [['workloads', organizationId, 'overview']],
enabled: Boolean(organizationId),
});
Expand Down
6 changes: 4 additions & 2 deletions src/pages/RunnerDetailPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,13 @@ export function RunnerDetailPage() {
const [labelEntries, setLabelEntries] = useState<LabelEntry[]>([]);
const [runnerName, setRunnerName] = useState('');
const [runnerNameError, setRunnerNameError] = useState('');
const notificationRooms = organizationId ? [`organization:${organizationId}`] : [];

useNotifications({
events: ['workload.status_changed', 'workload.updated'],
rooms: notificationRooms,
events: ['workload.updated'],
invalidateKeys: [['workloads', 'runner', runnerId]],
enabled: Boolean(runnerId),
enabled: Boolean(runnerId && organizationId),
});

const runnerQuery = useQuery({
Expand Down
1 change: 1 addition & 0 deletions src/pages/WorkloadDetailPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ export function WorkloadDetailPage() {
const location = useLocation();

useNotifications({
rooms: workloadId ? [`workload:${workloadId}`] : [],
events: ['workload.status_changed', 'workload.updated'],
Comment thread
noa-lucent marked this conversation as resolved.
invalidateKeys: [['workloads', workloadId, 'detail']],
enabled: Boolean(workloadId),
Expand Down
Loading