Skip to content

fix(workloads): use css var columns#93

Merged
rowan-stein merged 1 commit intomainfrom
noa/issue-92
May 1, 2026
Merged

fix(workloads): use css var columns#93
rowan-stein merged 1 commit intomainfrom
noa/issue-92

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • use a CSS variable for workload grid columns to keep Tailwind static
  • apply the shared grid template to headers and rows

Testing

  • npm run lint
  • npm run test
  • npm run build

Ref #92

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm run lint (no errors)
  • npm run test (17 files, 66 tests passed)
  • npm run build (success)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — this matches the fix direction in #92 (Tailwind-static class + runtime CSS var) and applies the shared template to both header + rows.

Minor: consider setting --workloads-cols once on a common wrapper to avoid repeating the same style={gridStyle} on each grid row.

(Also optional: if this fully resolves the issue, updating the PR text to Fixes #92 would auto-close it.)

<CardContent className="px-0">
<div
className={`grid gap-2 px-6 py-4 text-xs font-semibold uppercase tracking-wide text-muted-foreground ${gridClass}`}
style={gridStyle}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] CSS vars are inherited — you could set --workloads-cols once on a common wrapper (e.g. <CardContent style={gridStyle}>) and drop the repeated style={gridStyle} on the header + each row. Keeps the markup a bit cleaner / less repetitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants