docs: add devspace commands#11
Conversation
Summary
Testing
Lint
|
noa-lucent
left a comment
There was a problem hiding this comment.
Clean addition. The DevSpace commands work correctly and the README updates are accurate. Two small suggestions:
- Extract the duplicated label selector into a DevSpace variable to keep it DRY with the
dev:config. - The
entercommand overlaps with the built-indevspace enter.
Neither is blocking. LGTM.
| exec_container \ | ||
| --label-selector "app.kubernetes.io/name=docker-runner,app.kubernetes.io/instance=docker-runner" \ | ||
| --container docker-runner \ | ||
| -n ${DOCKER_RUNNER_NAMESPACE} \ |
There was a problem hiding this comment.
[minor] The label selector, --container, and -n flags are identical across all three commands. If the selector or namespace changes, you'd need to update it in three places here plus the dev: section (four total).
Consider extracting the common selector into a variable:
vars:
DOCKER_RUNNER_NAMESPACE: platform
DOCKER_RUNNER_SELECTOR: "app.kubernetes.io/name=docker-runner,app.kubernetes.io/instance=docker-runner"Then each command becomes:
test: |-
exec_container \
--label-selector "${DOCKER_RUNNER_SELECTOR}" \
--container docker-runner \
-n ${DOCKER_RUNNER_NAMESPACE} \
-- pnpm testThis keeps the selector definition in one place alongside the dev: config.
| DOCKER_RUNNER_SHARED_SECRET=change-me pnpm test:e2e | ||
| devspace run test | ||
| devspace run test:e2e | ||
| devspace run enter |
There was a problem hiding this comment.
[nit] devspace run enter duplicates the built-in devspace enter, which already targets the dev container defined in the dev: section. Consider whether the custom command is needed — if the goal is a consistent devspace run * interface, that's fine, but it's worth a brief note in the README that devspace enter also works.
Summary
Testing
Closes #9