Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

docs: add devspace commands#11

Merged
rowan-stein merged 1 commit intomainfrom
noa/issue-9
Mar 13, 2026
Merged

docs: add devspace commands#11
rowan-stein merged 1 commit intomainfrom
noa/issue-9

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • add devspace commands for test, test:e2e, and enter
  • update README to reference devspace run commands and in-cluster env setup

Testing

  • pnpm lint
  • pnpm test

Closes #9

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • added devspace commands for tests and shell access
  • refreshed README test instructions to use devspace run and note dev session

Testing

  • pnpm lint
  • pnpm test

Lint

  • eslint . (no errors)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean addition. The DevSpace commands work correctly and the README updates are accurate. Two small suggestions:

  1. Extract the duplicated label selector into a DevSpace variable to keep it DRY with the dev: config.
  2. The enter command overlaps with the built-in devspace enter.

Neither is blocking. LGTM.

Comment thread devspace.yaml
exec_container \
--label-selector "app.kubernetes.io/name=docker-runner,app.kubernetes.io/instance=docker-runner" \
--container docker-runner \
-n ${DOCKER_RUNNER_NAMESPACE} \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] The label selector, --container, and -n flags are identical across all three commands. If the selector or namespace changes, you'd need to update it in three places here plus the dev: section (four total).

Consider extracting the common selector into a variable:

vars:
  DOCKER_RUNNER_NAMESPACE: platform
  DOCKER_RUNNER_SELECTOR: "app.kubernetes.io/name=docker-runner,app.kubernetes.io/instance=docker-runner"

Then each command becomes:

  test: |-
    exec_container \
      --label-selector "${DOCKER_RUNNER_SELECTOR}" \
      --container docker-runner \
      -n ${DOCKER_RUNNER_NAMESPACE} \
      -- pnpm test

This keeps the selector definition in one place alongside the dev: config.

Comment thread README.md
DOCKER_RUNNER_SHARED_SECRET=change-me pnpm test:e2e
devspace run test
devspace run test:e2e
devspace run enter
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] devspace run enter duplicates the built-in devspace enter, which already targets the dev container defined in the dev: section. Consider whether the custom command is needed — if the goal is a consistent devspace run * interface, that's fine, but it's worth a brief note in the README that devspace enter also works.

@rowan-stein rowan-stein merged commit 38b1ccc into main Mar 13, 2026
1 check passed
@casey-brooks casey-brooks deleted the noa/issue-9 branch March 13, 2026 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite development README for in-cluster workflow

3 participants