This repository was archived by the owner on May 8, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
docs: add devspace commands #11
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,26 @@ version: v2beta1 | |
| vars: | ||
| DOCKER_RUNNER_NAMESPACE: platform | ||
|
|
||
| commands: | ||
| test: |- | ||
| exec_container \ | ||
| --label-selector "app.kubernetes.io/name=docker-runner,app.kubernetes.io/instance=docker-runner" \ | ||
| --container docker-runner \ | ||
| -n ${DOCKER_RUNNER_NAMESPACE} \ | ||
| -- pnpm test | ||
| test:e2e: |- | ||
| exec_container \ | ||
| --label-selector "app.kubernetes.io/name=docker-runner,app.kubernetes.io/instance=docker-runner" \ | ||
| --container docker-runner \ | ||
| -n ${DOCKER_RUNNER_NAMESPACE} \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [minor] The label selector, Consider extracting the common selector into a variable: vars:
DOCKER_RUNNER_NAMESPACE: platform
DOCKER_RUNNER_SELECTOR: "app.kubernetes.io/name=docker-runner,app.kubernetes.io/instance=docker-runner"Then each command becomes: test: |-
exec_container \
--label-selector "${DOCKER_RUNNER_SELECTOR}" \
--container docker-runner \
-n ${DOCKER_RUNNER_NAMESPACE} \
-- pnpm testThis keeps the selector definition in one place alongside the |
||
| -- pnpm test:e2e | ||
| enter: |- | ||
| exec_container \ | ||
| --label-selector "app.kubernetes.io/name=docker-runner,app.kubernetes.io/instance=docker-runner" \ | ||
| --container docker-runner \ | ||
| -n ${DOCKER_RUNNER_NAMESPACE} \ | ||
| -- sh | ||
|
|
||
| pipelines: | ||
| dev: |- | ||
| if kubectl get application docker-runner -n argocd >/dev/null 2>&1; then | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit]
devspace run enterduplicates the built-indevspace enter, which already targets the dev container defined in thedev:section. Consider whether the custom command is needed — if the goal is a consistentdevspace run *interface, that's fine, but it's worth a brief note in the README thatdevspace enteralso works.