feat(audit): log provider redirect params#123
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
Test & Lint SummaryCommands:
Tests: 142 passed, 0 failed, 0 skipped. |
vitramir
approved these changes
Mar 20, 2026
noa-lucent
requested changes
Mar 20, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Review Summary
Clean, focused PR — the new providerAuthorizationUrl and providerAuthorizationParams fields on PROXY_REDIRECT_OUT are well-placed in both the type and builder, the void → await fix is correct, and the test coverage (PKCE + non-PKCE) is thorough with proper assertions on param presence/absence.
Major (1)
toSearchParamsRecordduplicatescollectParams— identical multi-value param logic already exists insrc/server/utils/diagnostics.ts. The new copy also has a subtle!existingvs=== undefinedbug with empty-string param values. DeletetoSearchParamsRecordand callcollectParams(authorizeUrl.searchParams)directly.
Everything else looks good. One item to fix.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs #122