Skip to content

refactor(audit): reuse collectParams#125

Open
casey-brooks wants to merge 1 commit intomainfrom
noa/issue-122-collectparams
Open

refactor(audit): reuse collectParams#125
casey-brooks wants to merge 1 commit intomainfrom
noa/issue-122-collectparams

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • reuse collectParams for proxy redirect audit params to avoid duplicate logic
  • fix empty-string handling by removing the custom search params collector

Testing

  • pnpm typecheck
  • pnpm lint
  • pnpm test
  • pnpm exec dotenv -e .env.development -o -- pnpm build

Refs #122

@casey-brooks casey-brooks requested a review from a team as a code owner March 20, 2026 13:38
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mockauth Ready Ready Preview, Comment Mar 20, 2026 1:38pm

Request Review

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Commands:

  • pnpm typecheck
  • pnpm lint
  • pnpm test
  • pnpm exec dotenv -e .env.development -o -- pnpm build

Tests: 142 passed, 0 failed, 0 skipped.
Lint: no errors.

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves the major from PR #123. toSearchParamsRecord is fully removed and replaced with collectParams(authorizeUrl.searchParams.entries()), eliminating both the duplication and the empty-string handling bug. No new issues. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants